add model and serial to device listing#25
Merged
Conversation
Collaborator
Author
|
Related: home-assistant/core#14013 |
This was referenced Apr 21, 2018
|
Wondering, isn't the device ID already stable ? Edit: of course stable within this specific bridge, which means it'd have to be a combination of bridge identifier and device ID. |
Collaborator
Author
|
There are probably a few ways it could change, such as if you got a new bridge or did a factory reset or maybe even some firmware updates. The model and serial number of the switches themselves should be more reliable. |
gurumitts
approved these changes
Apr 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support the Home Assistant Entity Registry we need to be able to construct a stable identifier value for every device. I don't know the details of how Lutron issues serial numbers, but I assume a combination of model ID and serial number will be unique within every home.