Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Add …" with "Create …" for New Helper title #131253

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Nov 22, 2024

For consistency when creating new helpers all of them should follow the workflow via:

Create helper > Create helper > Create specific helper

Screenshot 2024-11-22 13 04 42

Screenshot 2024-11-22 13 05 55

The Generic thermostat is one of the last that have an "Add …" in their window title:

Screenshot 2024-11-22 13 07 03

This PR fixes this for full consistency across all Helpers.

Proposed change

Replace "Add" with "Create" in the 'title' string of the New helper window.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

For consistency when creating new helpers all of them should follow the workflow via:

Create Helper > Create New Helper > Create new helper type

The Generic thermostat is on of the last that have an "Add …" in their window title.

THis PR fixes this for full consistency across all Helpers.
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NoRi2909 👍

../Frenck

@frenck frenck merged commit 4b5a8bf into home-assistant:dev Nov 22, 2024
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants