Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small inconsistencies in Create/Add dialogs for different Helper types #128109

Open
NoRi2909 opened this issue Oct 10, 2024 · 1 comment · May be fixed by #131196
Open

Small inconsistencies in Create/Add dialogs for different Helper types #128109

NoRi2909 opened this issue Oct 10, 2024 · 1 comment · May be fixed by #131196
Labels
good first issue Issues that are suitable for first-time contributors. integration: helpers translations

Comments

@NoRi2909
Copy link
Contributor

NoRi2909 commented Oct 10, 2024

The problem

I ran into this while reviewing the German translation of these strings, because one localizer preferred to simply alter the German translations instead of reporting this as a bug for the English orginals.

I reverted those edits in Lokalise to report this here instead so we keep a close 1:1 relation between the different languages.

It's all keys with

 config::step::user::title

in them, so they should be easily locatable.

Most of the headlines for creating helpers start with "Create …"
but there are a few exceptions that should be made consistent:

 component::generic_thermostat::config::step::user::title
 Add generic thermostat                                     Done

 component::generic_hygrostat::config::step::user::title 
 Add generic hygrostat                                      Done

 component::derivative::config::step::user::title
 Add Derivative sensor                                      Done

 component::integration::config::step::user::title
 Add Riemann sum integral sensor                            Done

 component::threshold::config::step::user::title
 Add Threshold Sensor                                       Done

 component::group::config::step::user::title
 Add Group                                                  Done

 component::utility_meter::config::step::user::title 
 Add Utility Meter                                          PR filed

Those above should be changed to "Create …" to match the others.

This will help all translators to use a consistent wording, too.

What version of Home Assistant Core has the issue?

core-2024.10.1

@home-assistant
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors. integration: helpers translations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants