Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Add …" to "Create …" for consistency #131198

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Nov 21, 2024

Following Home Assistant Design guidelines anything a user creates should use "Create …" not "Add …".

The integral helper is among the few that still use "Add" for the headline of the Helper dialog:

image

Fixing this for consistency across all Helper types, too.

Proposed change

Replace "Add" with "Create" in the 'title' string of the Helper dialog.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Following HA guidelines anything a user creates should use "Create …" not "Add …".

Fixing this for consistency across all Helper types, too.
@home-assistant
Copy link

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (integration) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of integration can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign integration Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding an integration, thus the current text is IMHO consistent with any other place in Home Assistant right now?

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 21, 2024 19:52
@NoRi2909
Copy link
Contributor Author

@frenck I've added the screenshot above, this is the title of the Helper entity dialog.

We have about 20 helpers, 15 of those use "Create" and five remaining are inconsistent, using "Add" which is not correct to the Home Assistant Design guidelines: The user creates a new entity using this dialog, and you can create as many as you like.

This not about adding an integration, not in any way.

@NoRi2909 NoRi2909 requested a review from frenck November 21, 2024 20:17
@frenck
Copy link
Member

frenck commented Nov 21, 2024

@frenck I've added the screenshot above, this is the title of the Helper entity dialog.

I know, the fact is.... it adds an integration; for which we use "add", not "create".

@frenck frenck removed their request for review November 21, 2024 20:18
@NoRi2909
Copy link
Contributor Author

No @frenck , the dialog this PR addresses does not add an integration, it creates an entity.

It's Settings > Devices & Services > Helpers >

image

Then

image

And finally:

image

It says "Create" everywhere, just not that single "Add" I'm asking to change

@frenck
Copy link
Member

frenck commented Nov 21, 2024

Ok agreed, there it is different... confusing as if you go trough the add integration it would be "add"... seems like this has change though 👍

../Frenck

@frenck frenck marked this pull request as ready for review November 21, 2024 20:26
@home-assistant home-assistant bot requested a review from frenck November 21, 2024 20:26
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NoRi2909 👍

../Frenck

@frenck frenck merged commit 96849f2 into home-assistant:dev Nov 21, 2024
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@NoRi2909 NoRi2909 deleted the patch-26 branch February 7, 2025 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants