-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Add …" to "Create …" for consistency #131198
Conversation
Following HA guidelines anything a user creates should use "Create …" not "Add …". Fixing this for consistency across all Helper types, too.
Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is adding an integration, thus the current text is IMHO consistent with any other place in Home Assistant right now?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@frenck I've added the screenshot above, this is the title of the Helper entity dialog. We have about 20 helpers, 15 of those use "Create" and five remaining are inconsistent, using "Add" which is not correct to the Home Assistant Design guidelines: The user creates a new entity using this dialog, and you can create as many as you like. This not about adding an integration, not in any way. |
I know, the fact is.... it adds an integration; for which we use "add", not "create". |
No @frenck , the dialog this PR addresses does not add an integration, it creates an entity. It's Settings > Devices & Services > Helpers > Then And finally: It says "Create" everywhere, just not that single "Add" I'm asking to change |
Ok agreed, there it is different... confusing as if you go trough the add integration it would be "add"... seems like this has change though 👍 ../Frenck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @NoRi2909 👍
../Frenck
Following Home Assistant Design guidelines anything a user creates should use "Create …" not "Add …".
The integral helper is among the few that still use "Add" for the headline of the Helper dialog:
Fixing this for consistency across all Helper types, too.
Proposed change
Replace "Add" with "Create" in the 'title' string of the Helper dialog.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: