Skip to content

Fix sensibo default IDs to be according to schema #12837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Mar 2, 2018
Merged

Fix sensibo default IDs to be according to schema #12837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/climate/sensibo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

_LOGGER = logging.getLogger(__name__)

ALL = 'all'
ALL = ['all']
Copy link
Copy Markdown
Member

@balloob balloob Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary since voluptuous will pass ALL through the validator, which will be turned into a list by cv.ensure_list.

Copy link
Copy Markdown
Member

@balloob balloob Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Copy Markdown
Contributor Author

@andrey-git andrey-git Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part that fails is comparing the result (['all']) with ALL on line 73.

TIMEOUT = 10

SERVICE_ASSUME_STATE = 'sensibo_assume_state'
Expand Down