Fix sensibo default IDs to be according to schema#12837
Merged
balloob merged 1 commit intohome-assistant:devfrom Mar 2, 2018
Merged
Fix sensibo default IDs to be according to schema#12837balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
homeassistant
added
platform: climate.sensibo
small-pr
balloob
reviewed
Mar 2, 2018
| _LOGGER = logging.getLogger(__name__) | ||
|
|
||
| ALL = 'all' | ||
| ALL = ['all'] |
Member
There was a problem hiding this comment.
This shouldn't be necessary since voluptuous will pass ALL through the validator, which will be turned into a list by cv.ensure_list.
Contributor
Author
There was a problem hiding this comment.
The part that fails is comparing the result (['all']) with ALL on line 73.
Contributor
Author
|
I think the test failure is unrelated to this PR |
Member
|
Yeah that flaky test was my fault for merging. |
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix sensibo default IDs to be according to schema.
Related issue (if applicable): fixes #12757
Example entry for
configuration.yaml(if applicable):Checklist: