Conversation
Member
balloob
commented
Feb 17, 2018
balloob
commented
- python-miio version bumped. (Closes: xiaomi_miio not working #12389, Closes: Xiaomi Miio Vaccum still broken #12298) (@syssi - #12392) (fan.xiaomi_miio docs) (light.xiaomi_miio docs) (remote.xiaomi_miio docs) (switch.xiaomi_miio docs) (vacuum.xiaomi_miio docs)
- Fixed 3 small issues in isy994 component (@OverloadUT - #12421) (isy994 docs)
- Reduce the load on met.no servers, yr.no sensor (@danielhiversen - #12435) (sensor.yr docs)
- Fix for contentRating error (@ryanm101 - #12445) (media_player.plex docs)
- Fix light template to return brightness as int (@andrey-git - #12447) (light.template docs)
- Optimize recorder purge (@amelchio - #12448)
- [SQL Sensor] always close session (@dgomes - #12452) (sensor.sql docs)
1. FanLincs have two nodes: one light and one fan motor. In order for each node to get detected as different Hass entity types, I removed the device-type check for FanLinc. The logic will now fall back on the uom checks which should work just fine. (An alternative approach here would be to special case FanLincs and handle them directly - but seeing as the newer 5.x ISY firmware already handles this much better using NodeDefs, I think this quick and dirty approach is fine for the older firmware.) Fixes #12030 2. Some non-dimming switches were appearing as `light`s in Hass due to an duplicate NodeDef being in the light domain filter. Removed! Fixes #12340 3. The `unqiue_id` property was throwing an error for certain entity types that don't have an `_id` property from the ISY. This issue has always been present, but was exposed by the entity registry which seems to be the first thing to actually try reading the `unique_id` property from the isy994 component.
* Spread the load more for the yr.no sensor * Spread the load more for the yr.no sensor * Spread the load more for the yr.no sensor * Spread the load more for the yr.no sensor * Spread the load more for the yr.no sensor * Spread the load more for the yr.no sensor * Spread the load more for the yr.no sensor * Spread the load more for the yr.no sensor * Spread the load more for the yr.no sensor * fix comment * Spread the load more for the yr.no sensor * Spread the load more for the yr.no sensor * Spread the load more for the yr.no sensor * Update yr.py
* Fix for contentRating * Use getattr instead of hasattr * Lint
* close aborted session * blank line
balloob
requested review from
a team,
andrey-git and
rytilahti
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.