Fix for contentRating error in Plex#12445
Merged
balloob merged 3 commits intohome-assistant:devfrom Feb 16, 2018
ryanm101:plexfix
Merged
Fix for contentRating error in Plex#12445balloob merged 3 commits intohome-assistant:devfrom ryanm101:plexfix
balloob merged 3 commits intohome-assistant:devfrom
ryanm101:plexfix
Conversation
homeassistant
added
cla-signed
platform: media_player.plex
small-pr
balloob
reviewed
Feb 15, 2018
| self._media_position = self._session.viewOffset | ||
| self._media_content_id = self._session.ratingKey | ||
| self._media_content_rating = self._session.contentRating | ||
| self._media_content_rating = self._session.contentRating \ |
Member
There was a problem hiding this comment.
Instead, use getattr(self._session, 'contentRating', None)
houndci-bot
reviewed
Feb 16, 2018
| self._media_position = self._session.viewOffset | ||
| self._media_content_id = self._session.ratingKey | ||
| self._media_content_rating = self._session.contentRating | ||
| self._media_content_rating = getattr(self._session, 'contentRating', None) |
There was a problem hiding this comment.
line too long (86 > 79 characters)
balloob
approved these changes
Feb 16, 2018
ryanm101
changed the title
balloob
pushed a commit
that referenced
this pull request
Feb 17, 2018
* Fix for contentRating * Use getattr instead of hasattr * Lint
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12058