Conversation
balloob
force-pushed
the
platform-dependencies
branch
from
08a6b84 to
de65d88
Compare
balloob
added a commit
that referenced
this pull request
Feb 12, 2018
Merged
balloob
added a commit
that referenced
this pull request
Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I introduced a bug in #12051 where we would not process the dependencies and requirements of platforms if a component was already processed with an identical name. This is very common (ie bloomsky and sensor.bloomsky)
Related issue (if applicable): fixes #12288
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass