Conversation
pvizeli
approved these changes
Jan 30, 2018
Member
|
🐬 |
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Requirements are no longer installed directly in deps directory but in the library folder under the deps directory. That path is given by mounting the local lib path.
| 'constraints': os.path.join(os.path.dirname(__file__), CONSTRAINT_FILE) | ||
| } | ||
| if not pkg_util.running_under_virtualenv(): | ||
| kwargs['target'] = os.path.join(config_dir, 'deps') |
Member
There was a problem hiding this comment.
This is changing the target path. Target should be the library folder.
Member
There was a problem hiding this comment.
Nevermind, I'm wrong and remembered incorrectly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Minor cleanup of our setup process:
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass