Migrated SABnzbd sensor to asyncio and switched to pypi library#12290
Merged
balloob merged 2 commits intohome-assistant:devfrom Feb 11, 2018
Merged
Migrated SABnzbd sensor to asyncio and switched to pypi library#12290balloob merged 2 commits intohome-assistant:devfrom
balloob merged 2 commits intohome-assistant:devfrom
Conversation
32 tasks
balloob
approved these changes
Feb 11, 2018
Member
|
Ok to merge when tests pass. |
Contributor
|
Member
Author
|
Sorry guys, I'm not sure why I'm getting those errors. The package is on PyPI and everything is working locally. Am I missing something somewhere? |
Contributor
|
You have |
Contributor
|
I think |
Member
Author
|
@andrey-git thank you for finding this. Man, what a bonehead mistake. I went ahead and just moved the classes into |
Member
Author
|
Build log now showing and other similar errors. Is this #12283 related? |
Member
|
Yeah, it's super flaky 😢 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Created asyncio version of SABnzbd API library and published to PyPI. Migrated sabnzbd sensor to use asyncio and new pypi library.
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py.