Skip to content

Attempt fixing flakiness of check config test#12283

Merged
balloob merged 6 commits intodevfrom
flaky-check-config
Feb 11, 2018
Merged

Attempt fixing flakiness of check config test#12283
balloob merged 6 commits intodevfrom
flaky-check-config

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 10, 2018

Description:

Attempt address some flakiness for check config script tests

@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels Feb 10, 2018
@balloob balloob changed the title Attempt flakiness Attempt fixing flakiness of check config test Feb 11, 2018
@balloob balloob mentioned this pull request Feb 11, 2018
3 tasks
@balloob balloob merged commit 8b9eab1 into dev Feb 11, 2018
@balloob balloob deleted the flaky-check-config branch February 11, 2018 17:00
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Feb 11, 2018

Merging it and hope that it makes a difference. The flakiness is horrible.

@kellerza
Copy link
Copy Markdown
Member

setLevel will defnitely be an improvement over the 6 statements in SILENCE!

Just for my clarity, mock_coro is only really needed for async_enable_logging?

Still want to work on this to reduce mocks, my current plan was:

  1. Mock based loading of the yaml config (I see no other way to do and drill down into details of files/secrets)
  2. Instead of using bootstrap, write something to do the voluptuous checks

If you have other ideas, I'll move thi to the architecture forum

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Feb 11, 2018

I think that if you go for 2 we don't need any of the mocks. Just a simple config loader. We can even break out some of the parts in Home Assistant to make them more easily usable inside the check config script.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Feb 11, 2018

mock_coro is indeed only necessary for any coroutine that is mocked and does nothing for the others

@balloob balloob mentioned this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants