Attempt fixing flakiness of check config test#12283
Merged
Conversation
82691be to
f79f70d
Compare
3 tasks
5 tasks
Member
Author
|
Merging it and hope that it makes a difference. The flakiness is horrible. |
Member
|
Just for my clarity, Still want to work on this to reduce mocks, my current plan was:
If you have other ideas, I'll move thi to the architecture forum |
Member
Author
|
I think that if you go for 2 we don't need any of the mocks. Just a simple config loader. We can even break out some of the parts in Home Assistant to make them more easily usable inside the check config script. |
Member
Author
|
mock_coro is indeed only necessary for any coroutine that is mocked and does nothing for the others |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Attempt address some flakiness for check config script tests