Skip to content

Fix some rfxtrx devices with multiple sensors #12264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielhiversen merged 2 commits into from
Feb 10, 2018
Merged

Fix some rfxtrx devices with multiple sensors #12264

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ec6a31
Fix some rfxtrx devices with multiple sensors
neffs Feb 9, 2018
e46d6e3
Add comment
neffs Feb 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions homeassistant/components/sensor/rfxtrx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,16 @@ def sensor_update(event):

if device_id in rfxtrx.RFX_DEVICES:
sensors = rfxtrx.RFX_DEVICES[device_id]
for key in sensors:
sensor = sensors[key]
for data_type in sensors:
if data_type not in event.values:

@Danielhiversen Danielhiversen Feb 10, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment to describe this?

@neffs neffs Feb 10, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done

continue
sensor = sensors[data_type]
sensor.event = event
# Fire event
if sensors[key].should_fire_event:
if sensor.should_fire_event:
sensor.hass.bus.fire(
"signal_received", {
ATTR_ENTITY_ID: sensors[key].entity_id,
ATTR_ENTITY_ID: sensor.entity_id,
}
)
return
Expand Down