Fix some rfxtrx devices with multiple sensors#12264
Merged
Danielhiversen merged 2 commits intohome-assistant:devfrom Feb 10, 2018
neffs:dev
Merged
Fix some rfxtrx devices with multiple sensors#12264Danielhiversen merged 2 commits intohome-assistant:devfrom neffs:dev
Danielhiversen merged 2 commits intohome-assistant:devfrom
neffs:dev
Conversation
Some combined temperature/humidity sensors send one packet for each of their sensors. Without this fix one of the home assistant sensors would always display an unknown value.
Contributor
homeassistant
added
platform: sensor.rfxtrx
cla-needed
cla-signed
and removed
cla-needed
labels
Danielhiversen
requested changes
Feb 10, 2018
| for key in sensors: | ||
| sensor = sensors[key] | ||
| for data_type in sensors: | ||
| if data_type not in event.values: |
Member
There was a problem hiding this comment.
Could you add a comment to describe this?
Member
|
Have you tested the code locally? For the next time. There is a pull request template, that you are supposed to fill out, and it has a check list that you should mark. |
Contributor
Author
|
I tested it as a custom component locally and my combined temperature/humidity sensor (LaCrosse protocol) works properly now. I created this pull request from the desktop app, where no template is shown. Sorry! Next time I'll use the template. |
Member
|
👍 |
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some combined temperature/humidity sensors send one packet for each of
their sensors. Without this fix one of the home assistant sensors would
always display an unknown value.