Use API to discover Hue if no bridges specified#11909
Merged
Merged
Conversation
balloob
commented
Jan 25, 2018
| """Apply decorator.""" | ||
| from unittest.mock import MagicMock, patch | ||
|
|
||
| def __enter__(self): |
Member
Author
There was a problem hiding this comment.
Rewriting MockDependency so that it can be used as both a decorator and a context manager.
pvizeli
approved these changes
Jan 25, 2018
| config = config.get(DOMAIN) | ||
| if config is None: | ||
| config = {} | ||
| conf = config.get(DOMAIN) |
Member
There was a problem hiding this comment.
Use an empty dictionary as default value.
Member
Author
There was a problem hiding this comment.
Good point. I just copied that from the original code.
Member
Author
There was a problem hiding this comment.
Damn you're on a roll with good code reviews Martin!
Merged
matemaciek
pushed a commit
to matemaciek/home-assistant
that referenced
this pull request
Jan 27, 2018
* upstream/master: (465 commits) Update pyhomematic to 0.1.38 (home-assistant#11936) Implement Alexa temperature sensors (home-assistant#11930) Fixed rfxtrx binary_sensor KeyError on missing optional device_class (home-assistant#11925) Allow setting climate devices to AUTO mode via Google Assistant (home-assistant#11923) fixes home-assistant#11848 (home-assistant#11915) Add "write" service to system_log (home-assistant#11901) Update frontend to 20180126.0 Version 0.62 Allow separate command and state OIDs and payloads in SNMP switch (home-assistant#11075) Add ERC20 tokens to etherscan.io sensor (home-assistant#11916) Report scripts and groups as scenes to Alexa (home-assistant#11900) Minor fix to configuration validation and related log line. (home-assistant#11898) Multi-Room Support for Greenwave Reality (home-assistant#11364) Added Xeoma camera platform (home-assistant#11619) Improve foscam library exception support (home-assistant#11701) Iota wallet (home-assistant#11398) New venstar climate component (home-assistant#11639) Update python-wink version and multiple wink fixes/updates. (home-assistant#11833) Use API to discover Hue if no bridges specified (home-assistant#11909) Clarify emulated hue warning (home-assistant#11910) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
No longer require the user to configure the Hue bridge. If no bridges specified, query the Philips Hue discovery API and use those bridges instead.
API will only be queried if: user configured the
huecomponent to be loaded but did not specify any bridge configs. API will not be queried if Hue is loaded via discovery (because then no entry in the config).Phue is a bit weird as a dependency because it enforces reading/writing to a file. The config would be a lot easier if we could store all config for all bridges in 1 file.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):hue:Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass