BME680: Minor fix to configuration validation and related log line.#11898
Conversation
|
Something failed in the test case for the travis build but this is not related to my code which passed local tests. It seems to be something related to the Travis build environment missing a component (unrelated to this PR) for the Python 3.5.3 environment only. I don't know how to request the Travis build to retry without submitting further changes. Please assist. |
|
Since you have previously reviewed my code.... Could you please help take a look at the Travis build for this. I believe the issue is not with my code but with the Travis build for 3.5.3. The error is it can't find the beer.py custom_component. This appears to be related to your testing setup and not my code. |
|
I restarted the Travis build. You can do that yourself by closing and reopening the PR. |
|
@MartinHjelmare Thanks. Will remember that for future. |
* upstream/master: (465 commits) Update pyhomematic to 0.1.38 (home-assistant#11936) Implement Alexa temperature sensors (home-assistant#11930) Fixed rfxtrx binary_sensor KeyError on missing optional device_class (home-assistant#11925) Allow setting climate devices to AUTO mode via Google Assistant (home-assistant#11923) fixes home-assistant#11848 (home-assistant#11915) Add "write" service to system_log (home-assistant#11901) Update frontend to 20180126.0 Version 0.62 Allow separate command and state OIDs and payloads in SNMP switch (home-assistant#11075) Add ERC20 tokens to etherscan.io sensor (home-assistant#11916) Report scripts and groups as scenes to Alexa (home-assistant#11900) Minor fix to configuration validation and related log line. (home-assistant#11898) Multi-Room Support for Greenwave Reality (home-assistant#11364) Added Xeoma camera platform (home-assistant#11619) Improve foscam library exception support (home-assistant#11701) Iota wallet (home-assistant#11398) New venstar climate component (home-assistant#11639) Update python-wink version and multiple wink fixes/updates. (home-assistant#11833) Use API to discover Hue if no bridges specified (home-assistant#11909) Clarify emulated hue warning (home-assistant#11910) ...
Description:
This is a minor fix to a voluptuous configuration type check that was set as string but should have been int. This did not stop the code from working but may have caused invalid error messages with a string value that could not be converted properly such as a config typo.
Note that the documentation, already states int correctly.
Related issue (if applicable): N/A
**Pull request in home-assistant.github.io with documentation (if applicable): N/A no change
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.