Revert setting communication delay in Risco init#113497
Merged
Merged
Conversation
Contributor
Author
|
CC @FredericMa |
joostlek
approved these changes
Mar 15, 2024
Member
The event loop shouldn't get blocked for more than 100ms in 2024.4.x during startup anymore from python imports (or hopefully anything else). Previous version had event loop blocks > 10s when importing large integrations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Revert setting the communication delay during Risco init, which can prevent the integration from loading during boot, in a way that's hard to recover from.
More info:
#101349 introduced a communication delay between connecting to a Risco panel and sending the first command. This was needed for some panels to work. The communication delay was set either through the config flow, or during init.
The former was ok. The latter seemed ok at the time based on two assumptions:
Both assumptions proved to be false:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: