Add Risco communication delay

[FredericMa]

Breaking change

Proposed change

This PR add an optional communication_delay parameter to the config flow that introduces a delay in between the opening of the socket and the communication over the socket. This has been implemented in the upstream package in OnFreund/pyrisco#17

Package bump compare: OnFreund/pyrisco@v0.5.7...v0.5.8

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR might be related to issue: Cannot install Risco integration using local option with panel RP512 panel #87008
• Link to documentation pull request: Obsolete Add communication delay docs home-assistant.io#29139

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @OnFreund, mind taking a look at this pull request as it has been labeled with an integration (risco) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of risco can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign risco Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[frenck]

Marking this PR draft for now. Feel free to undraft when the above discussion has been resolved and the PR is ready for review again.

../Frenck

[FredericMa]

@OnFreund Can you please give your opinion on the proposed way to continue this PR. If we make a decision I can finish the PR with some additional changes.

[OnFreund]

I'm sorry, given the situation in Israel I won't be able to meaningfully review this any time soon.

[FredericMa]

I'm sorry, given the situation in Israel I won't be able to meaningfully review this any time soon.

Sure, I fully understand. I hope you and your family and friends are all fine! Take care!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[MartinHjelmare]

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

[FredericMa]

All done! Thanks for the review.

[MartinHjelmare]

Thanks!

[MartinHjelmare]

@OnFreund are you happy to merge now? Should this PR wait to be released in the next minor release in December or do we consider it a fix?

[OnFreund]

Looks good to me, but missing a test for the case where the delay is updated outside the config flow.

Since this is not a recent regression, and the fix is not trivial, I would be inclined to wait for the December release, but I don't feel strongly either way.