Skip to content

Add initial communication delay after opening the local connection#17

Merged
OnFreund merged 2 commits into
OnFreund:masterfrom
FredericMa:initial_communication_delay
Sep 25, 2023
Merged

Add initial communication delay after opening the local connection#17
OnFreund merged 2 commits into
OnFreund:masterfrom
FredericMa:initial_communication_delay

Conversation

@FredericMa
Copy link
Copy Markdown
Contributor

Fixes #15

@FredericMa
Copy link
Copy Markdown
Contributor Author

@OnFreund Another friendly ping for this PR in case you also didn't receive a notification on this one.

Comment thread pyrisco/local/risco_socket.py Outdated
Check if delay is > 0.

Co-authored-by: On Freund <onfreund@gmail.com>
Copy link
Copy Markdown
Owner

@OnFreund OnFreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FredericMa!

@OnFreund OnFreund merged commit 6d619dd into OnFreund:master Sep 25, 2023
@OnFreund
Copy link
Copy Markdown
Owner

@FredericMa with the increased timeout in version 0.6.1 this might not be needed anymore. Can you test it?

@FredericMa
Copy link
Copy Markdown
Contributor Author

Hi, sorry for the late reply. It has been a busy weekend.
I just tested it but using a 0 second delay still fails. If I use the 1 second delay, all works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CannotConnectError on local connection

2 participants