Skip to content

Fix brand images for Aurora ABB Powerone int.#1385

Closed
adrianmihalko wants to merge 8 commits intohome-assistant:masterfrom
adrianmihalko:aurora_abb_powerone
Closed

Fix brand images for Aurora ABB Powerone int.#1385
adrianmihalko wants to merge 8 commits intohome-assistant:masterfrom
adrianmihalko:aurora_abb_powerone

Conversation

@adrianmihalko
Copy link
Copy Markdown
Contributor

Proposed change

Fix Aurora ABB Solar PV brand images as requested by @davet2001 in #1354. Thanks!

Type of change

  • Add a new logo or icon for a new integration
  • Add a missing icon or logo for an existing integration
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@adrianmihalko adrianmihalko changed the title Aurora abb powerone Fix brand images for Aurora ABB Powerone int. Apr 16, 2020
cogneato
cogneato previously approved these changes Apr 17, 2020
Copy link
Copy Markdown
Contributor

@cogneato cogneato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adrianmihalko

frenck
frenck previously approved these changes Apr 17, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 17, 2020

@adrianmihalko A wild merge conflict appeared... could you take a look?

Thanks 👍

@adrianmihalko adrianmihalko dismissed stale reviews from frenck and cogneato via 448a68e April 17, 2020 07:39
@adrianmihalko
Copy link
Copy Markdown
Contributor Author

@adrianmihalko A wild merge conflict appeared... could you take a look?

Thanks 👍

Yea, I removed symlinked directory, after merge I will post new images.

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 17, 2020

Thanks for updating by now I have:

image

So this PR is empty?

@adrianmihalko
Copy link
Copy Markdown
Contributor Author

Thanks for updating by now I have:

image

So this PR is empty?

Hmm, let's try. As you can see in dcd8d33 I removed just symlink, otherwise if I remove and post new files it shows as conflict.

@adrianmihalko
Copy link
Copy Markdown
Contributor Author

Yeah, I have no ide why it shows up as conflicting file:

Conflicting files
src/aurora_abb_powerone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants