Skip to content

Add brand images for Aurora ABB Solar PV integration#1354

Merged
frenck merged 3 commits intohome-assistant:masterfrom
adrianmihalko:aurora_abb_powerone
Apr 15, 2020
Merged

Add brand images for Aurora ABB Solar PV integration#1354
frenck merged 3 commits intohome-assistant:masterfrom
adrianmihalko:aurora_abb_powerone

Conversation

@adrianmihalko
Copy link
Copy Markdown
Contributor

@adrianmihalko adrianmihalko commented Apr 15, 2020 •
edited
Loading

Proposed change

Add brand images for Aurora ABB Solar PV integration. Separate logo is not existing, so I added only icons.

Type of change

  • Add a new logo or icon for a new integration
  • Add a missing icon or logo for an existing integration
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@adrianmihalko adrianmihalko mentioned this pull request Apr 15, 2020
Merged
8 tasks
@frenck frenck marked this pull request as draft April 15, 2020 18:37
@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 15, 2020

Converted PR to draft.

@adrianmihalko adrianmihalko marked this pull request as ready for review April 15, 2020 19:08
frenck
frenck approved these changes Apr 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

frenck
frenck approved these changes Apr 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frenck frenck merged commit 95225ea into home-assistant:master Apr 15, 2020
@davet2001
Copy link
Copy Markdown

davet2001 commented Apr 16, 2020

There’s a problem here.

Aurora NOAA is not the same as the Aurora brand of solar inverters. They are two completely different organisations with different logos.

https://www.google.co.uk/imgres?imgurl=http://www.ausindsolar.com.au/wp-content/uploads/2015/03/ausind-solar-aurora_spread.jpg&imgrefurl=http://www.ausindsolar.com.au/ABB-powerone-inverter/&tbnid=KxBgIoqIyNUIbM&vet=1&docid=XjQL5PSfmaE57M&w=325&h=321&itg=1&q=aurora+abb&hl=en-gb&source=sh/x/im

In reality the aurora and power one brands are legacy now anyway, as they were bought by ABB and new ones are now fully branded as ABB or ABB UNO.

https://resources.news.e.abb.com/images/2019/11/27/0/ffd8b44b3e7621e7c1258101003e0760_d3539538-8543-4159-8637-4dd97f26fbaf_ABB_Solar_City_6_508.jpg

I am not sure of the best way to handle this In homeassistant (rename the integration?) but the NOAA logo is definitely not correct.

Probably ABB is the most accurate logo to use now.

@adrianmihalko
Copy link
Copy Markdown
Contributor Author

adrianmihalko commented Apr 16, 2020

Thanks @davet2001, I will fix this.

@adrianmihalko adrianmihalko changed the title Add brand images for Aurora NOAA intogration Add brand images for Aurora ABB inte Solar PV integration Apr 16, 2020
@adrianmihalko adrianmihalko changed the title Add brand images for Aurora ABB inte Solar PV integration Add brand images for Aurora ABB Solar PV integration Apr 16, 2020
This was referenced Apr 16, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Aurora ABB Solar PV is missing brand images

3 participants

@adrianmihalko @frenck @davet2001