Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authorization check bug #5504

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix authorization check bug #5504

merged 2 commits into from
Sep 13, 2023

Commits on Sep 12, 2023

  1. Fix authorization check bug 

    This commit adds some extra logic, and error messages around user
authentication with a user supplied `authorize_callback` method.

- Adds more messaging around the `RuntimeError` when an error occurs
  during authorization checks.
- Adds messaging to a user attempting access a path they do not have
  access to.
- Adds logic to ensure if an `authorize_callback` has only 1 parameter,
  it does not cause a `RuntimeError`.

Resolves holoviz#5503
    @ndmlny-qs
    ndmlny-qs committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    504e92e View commit details
    Browse the repository at this point in the history

  2. PR comments

    @ndmlny-qs
    ndmlny-qs committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    d9a7f0d View commit details
    Browse the repository at this point in the history