Fix authorization check bug #5504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some extra logic, and error messages around user authentication with a user supplied `authorize_callback` method. - Adds more messaging around the `RuntimeError` when an error occurs during authorization checks. - Adds messaging to a user attempting access a path they do not have access to. - Adds logic to ensure if an `authorize_callback` has only 1 parameter, it does not cause a `RuntimeError`. Resolves holoviz#5503
Codecov Report
@@ Coverage Diff @@
## main #5504 +/- ##
==========================================
- Coverage 83.55% 82.69% -0.86%
==========================================
Files 276 276
Lines 40147 40152 +5
==========================================
- Hits 33543 33205 -338
- Misses 6604 6947 +343
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
el-abcd
reviewed
Sep 12, 2023
el-abcd
approved these changes
Sep 12, 2023
el-abcd
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some extra logic, and error messages around user authentication with a user supplied
authorize_callbackmethod.RuntimeErrorwhen an error occurs during authorization checks.authorize_callbackhas only 1 parameter, it does not cause aRuntimeError.Resolves #5503