Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NumPy integer/floating checks on Perspective #4366

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Conversation

philippjfr
Copy link
Member

Fix #4362

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #4366 (8883570) into main (e459067) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4366      +/-   ##
==========================================
- Coverage   70.30%   70.29%   -0.02%     
==========================================
  Files         240      240              
  Lines       34802    34802              
==========================================
- Hits        24469    24464       -5     
- Misses      10333    10338       +5     
Flag Coverage Δ
unitexamples-tests 70.29% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/perspective.py 59.46% <0.00%> (ø)
panel/widgets/debugger.py 89.39% <0.00%> (-3.04%) ⬇️
panel/models/tabulator.py 96.70% <0.00%> (-1.10%) ⬇️
panel/io/state.py 70.12% <0.00%> (-0.18%) ⬇️
panel/template/base.py 76.64% <0.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 8fe226f into main Jan 30, 2023
@philippjfr philippjfr deleted the perspective_float branch January 30, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message when passing pd.NA to Perspective
1 participant