Fix NumPy integer/floating checks on Perspective (#4366)

holoviz · Jan 30, 2023 · 8fe226f · 8fe226f
1 parent e459067
commit 8fe226f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -60,6 +60,7 @@ This release introduces a large number of bug fixes and minor enhancements. Due
 - Upgrade plotly.js to 2.10.1 ([#4320](https://github.com/holoviz/panel/pull/4320))
 - Upgrade to pyodide 0.22.1 in `panel convert` ([#4334](https://github.com/holoviz/panel/pull/4334))
 - Upgrade to pyscript 2022.12.01 in `panel convert` ([#4334](https://github.com/holoviz/panel/pull/4334))
+- Fix compatibility of Perspective pane with Numpy 1.24 ([#4362](https://github.com/holoviz/panel/issues/4362))
 
 ### Deprecations
 

diff --git a/doc/about/releases.md b/doc/about/releases.md
@@ -62,6 +62,7 @@ This release introduces a large number of bug fixes and minor enhancements. Due
 - Upgrade plotly.js to 2.10.1 ([#4320](https://github.com/holoviz/panel/pull/4320))
 - Upgrade to pyodide 0.22.1 in `panel convert` ([#4334](https://github.com/holoviz/panel/pull/4334))
 - Upgrade to pyscript 2022.12.01 in `panel convert` ([#4334](https://github.com/holoviz/panel/pull/4334))
+- Fix compatibility of Perspective pane with Numpy 1.24 ([#4362](https://github.com/holoviz/panel/issues/4362))
 
 ### Deprecations
 

diff --git a/panel/pane/perspective.py b/panel/pane/perspective.py
@@ -424,10 +424,10 @@ def _init_params(self):
                         schema[col] = 'datetime'
                     elif isinstance(value, str):
                         schema[col] = 'string'
-                    elif isinstance(value, (float, np.float)):
-                        schema[col] = 'float'
-                    elif isinstance(value, (int, np.int)):
+                    elif isinstance(value, (float, np.floating)):
                         schema[col] = 'float'
+                    elif isinstance(value, (int, np.integer)):
+                        schema[col] = 'integer'
                     else:
                         schema[col] = 'string'
                 else: