Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type annotations on convert_app(s) #4342

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Fix type annotations on convert_app(s) #4342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 10 additions & 4 deletions panel/io/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,8 @@ def script_to_html(


def convert_app(
app: str,
dest_path: str,
app: str | os.PathLike,
dest_path: str | os.PathLike | None = None,
requirements: List[str] | Literal['auto'] | os.PathLike = 'auto',
runtime: Runtimes = 'pyodide-worker',
prerender: bool = True,
Expand All @@ -351,6 +351,11 @@ def convert_app(
http_patch: bool = True,
verbose: bool = True,
):
if dest_path is None:
dest_path = pathlib.Path('./')
elif not isinstance(dest_path, pathlib.PurePath):
dest_path = pathlib.Path(dest_path)

try:
with set_resource_mode('cdn'):
html, js_worker = script_to_html(
Expand All @@ -365,6 +370,7 @@ def convert_app(
return
name = '.'.join(os.path.basename(app).split('.')[:-1])
filename = f'{name}.html'

with open(dest_path / filename, 'w', encoding="utf-8") as out:
out.write(html)
if runtime == 'pyodide-worker':
Expand Down Expand Up @@ -403,8 +409,8 @@ def _convert_process_pool(
return files

def convert_apps(
apps: List[str],
dest_path: str | None = None,
apps: str | os.PathLike | List[str | os.PathLike],
dest_path: str | os.PathLike | None = None,
title: str | None = None,
runtime: Runtimes = 'pyodide-worker',
requirements: List[str] | Literal['auto'] | os.PathLike = 'auto',
Expand Down