Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotations on convert_app(s) #4342

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Fix type annotations on convert_app(s) #4342

merged 1 commit into from
Jan 27, 2023

Conversation

philippjfr
Copy link
Member

Fixes #3945

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #4342 (5f1fd46) into main (56a64cb) will decrease coverage by 0.16%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #4342      +/-   ##
==========================================
- Coverage   82.77%   82.61%   -0.16%     
==========================================
  Files         240      240              
  Lines       34599    34603       +4     
==========================================
- Hits        28639    28587      -52     
- Misses       5960     6016      +56     
Flag Coverage Δ
ui-tests 37.99% <50.00%> (-0.30%) ⬇️
unitexamples-tests 73.80% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/convert.py 71.77% <50.00%> (-0.36%) ⬇️
panel/tests/ui/widgets/test_misc.py 33.33% <0.00%> (-64.11%) ⬇️
panel/tests/ui/io/test_jupyter_server_extension.py 50.00% <0.00%> (-50.00%) ⬇️
panel/tests/ui/io/test_jupyterlite.py 89.74% <0.00%> (-7.70%) ⬇️
panel/tests/util.py 87.37% <0.00%> (-3.89%) ⬇️
panel/tests/ui/io/test_convert.py 93.10% <0.00%> (-2.59%) ⬇️
panel/tests/conftest.py 88.08% <0.00%> (-1.28%) ⬇️
panel/io/state.py 70.46% <0.00%> (-0.18%) ⬇️
panel/widgets/indicators.py 72.24% <0.00%> (-0.16%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit c68461a into main Jan 27, 2023
@philippjfr philippjfr deleted the convert_types branch January 27, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In convert_app incorrect type annotation for dest_path leads to exception.
1 participant