Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for jupyter_client before patching event_loop on Windows #3770

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Check for jupyter_client before patching event_loop on Windows #3770

merged 2 commits into from
Aug 22, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 22, 2022

Fixes #3627 related to importing panel in the IPython startup folder.

@philippjfr
Copy link
Member

Why partially?

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #3770 (4f9e39d) into master (4f8ab43) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master    #3770   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files         214      214           
  Lines       31348    31367   +19     
=======================================
+ Hits        26198    26215   +17     
- Misses       5150     5152    +2     
Flag Coverage Δ
ui-tests 33.85% <0.00%> (-0.02%) ⬇️
unitexamples-tests 76.46% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/server.py 76.59% <66.66%> (+0.02%) ⬆️
panel/widgets/tables.py 89.16% <0.00%> (ø)
panel/command/serve.py 37.11% <0.00%> (+0.39%) ⬆️
panel/config.py 60.22% <0.00%> (+0.55%) ⬆️
panel/io/document.py 66.37% <0.00%> (+1.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro
Copy link
Member Author

hoxbro commented Aug 22, 2022

It does not fix IndexError: pop from an empty deque, but I can see in the thread that this is not related to panel.

@philippjfr philippjfr merged commit b440393 into holoviz:master Aug 22, 2022
@philippjfr
Copy link
Member

Thanks @hoxbro!

@hoxbro hoxbro deleted the slow_panel_import branch August 22, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance problems with panel > 0.13 and Lab3
2 participants