-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance problems with panel > 0.13 and Lab3 #3627
Comments
I was aware of performance regressions in 0.13.0 (see #3531) but was under the impression these were fixed. You are certain you have updated to 0.13.1 in your base env (the one that the Jupyter server is running in)? |
Hey @philippjfr, I'm working with @ItamarShDev, we did tried 0.13.1 and even 0.14.0a1 and 0.14.0a2, but the problems listed above consisted. |
Thanks for the update, someone will have to do a bisection on the codebase. Can you give me a very simple, step-wise recipe that will reproduce the issue so that bisection doesn't take forever? |
The first two sections written above are hard to reproduce The first one (the general slowness) is always there from the moment we starting Jupyter (with panel imported trough the startup folder). The second one (the kernel crashes) are happening suddenly during work, and the exception mentioned above is shown in the logs. The third one (kernel wont start / crash) I can reproduce easily in windows, I'm creating a file with just line for importing panel and save it under the startup folder ( We posted the list of packages above we are using above, we are using just to make it clearer when go back to older panel (0.12.7 and below) stuff are smoother, the kernel exception didn't happened during my test time and the import from windows using the startup folder worked smoothly and the kernel started without any issue. LMK if you need any other information. thanks. |
Thanks, that's very helpful! |
Hey @philippjfr, do you have any news for us ? |
If any tess are needed, we will be happy to test |
Sorry, don't have any updates yet. Been a little swamped. Hope to have some time tomorrow. |
Thanks for the response @philippjfr, looking forward for it. |
I also experience this when working on my windows laptop on the current Panel master branch. |
Sorry I haven't gotten to this. Unfortunately I've been travelling almost non stop for weeks and havent had access to a windows machine. |
On this amazing youtube video by Thu Vue she has to state around minute 04:00 that you should not install Panel in the same virtual environment as Jupyterlab due to some weird issue https://www.youtube.com/watch?v=B11nK1QCPRA. I believe this is most important bug to fix for Panel as you cannot currently work with the latest version of Panel and Jupyter lab on Windows if you are not an experienced user willing to put in some effort to get it working. |
Would be happy to backport this to a 0.13.x release asap if we figure out what is causing it. If someone with a windows machine could do a git bisect that would be tremendously helpful. I won't be able to do it until Sunday at the very earliest. |
@philippjfr If you could guide me through, i can give you any Windows related info. |
So sorry this has taken so long but I was finally able to test this on windows and I have had absolutely no luck reproducing the issue. Maybe we can sync at some point and debug together. |
By using the first environment on Windows and adding Lines 538 to 545 in 8c5ca7a
I could not see any slowness except that. The log message in the first comment also seems to indicate it running on Linux and not Windows. |
Wow, great sleuthing thanks! Could you submit a PR adding that additional guard? |
Note that the |
We are experiencing some performance behaviors with panel > 0.13
The problems we are facing are:
We get the following error:
Here is the boken system pip list:
And here is a pip list of the working environment:
The text was updated successfully, but these errors were encountered: