Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose req to genid function similar to express-session #372

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zignis
Copy link

@zignis zignis commented Oct 16, 2022

Pass the request object to the id generator function as done by express-session, to allow generating session ids based off of some data in the request.

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2022

⚠️ No Changeset found

Latest commit: d6c85d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #372 (d6c85d7) into master (5615e7d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files           6        6           
  Lines         121      121           
  Branches       37       36    -1     
=======================================
  Hits          120      120           
  Misses          1        1           
Impacted Files Coverage Δ
src/types.ts 0.00% <ø> (ø)
src/session.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zignis zignis changed the title Pass req to genid function similar to express-session Expose req to genid function similar to express-session Oct 16, 2022
@dbelcher-godaddy
Copy link

Any update on this? Our current project could use this feature.

@zignis
Copy link
Author

zignis commented Aug 22, 2023

Any update on this? Our current project could use this feature.

It's more than a year since the last commit on this repo, and I'm afraid if it is being maintained anymore. Meanwhile, you can use my fork which includes the changes in this PR: @zignis/next-session

Copy link
Owner

@hoangvvo hoangvvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I can release a new version once this is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants