Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create nextApiHandlerWithSession method #209

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hsh2001
Copy link

@hsh2001 hsh2001 commented Jul 20, 2020

Update for hoangvvo#206

Create NextApiRequestWithSession interface

Create NextApiHandlerWithSession interface

Create nextApiHandlerWithSession method
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #209 into master will increase coverage by 0.17%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   94.59%   94.76%   +0.17%     
==========================================
  Files           7        9       +2     
  Lines         185      172      -13     
  Branches       52       45       -7     
==========================================
- Hits          175      163      -12     
- Misses          2        3       +1     
+ Partials        8        6       -2     
Impacted Files Coverage Δ
src/withSession.ts 80.00% <66.66%> (-3.34%) ⬇️
src/compat.ts 95.00% <0.00%> (-5.00%) ⬇️
src/types.ts 100.00% <0.00%> (ø)
src/connect.ts 100.00% <0.00%> (ø)
src/store/memory.ts 100.00% <0.00%> (ø)
src/session.ts 91.42% <0.00%> (ø)
src/cookie.ts 100.00% <0.00%> (ø)
src/core.ts 96.55% <0.00%> (+3.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc04104...883ed2a. Read the comment docs.

@hoangvvo
Copy link
Owner

I would wait until we deprecate withSession usage with Page (only support API Routes afterward)

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2020

⚠️ No Changeset found

Latest commit: 883ed2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants