Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re enable fastmnn #569

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Re enable fastmnn #569

merged 3 commits into from
Dec 2, 2021

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented Nov 28, 2021

Background

Link to issue

see pipeline PR

Link to staging deployment URL

https://ui-alex-ui569-pipe190.scp-staging.biomage.net/

Links to any Pull Requests related to this

hms-dbmi-cellenics/pipeline#190

Anything else the reviewers should know about the changes here

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format
  • Validated that current unit tests work as expected and are enough

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
  • Deployed to staging
  • Passed integration tests

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #569 (009b3ed) into master (da9508a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #569   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files         151      151           
  Lines        4604     4604           
  Branches      883      883           
=======================================
  Hits         3290     3290           
  Misses       1299     1299           
  Partials       15       15           
Impacted Files Coverage Δ
...a-processing/DataIntegration/CalculationConfig.jsx 77.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da9508a...009b3ed. Read the comment docs.

@alexvpickering alexvpickering merged commit 58517cf into master Dec 2, 2021
@alexvpickering alexvpickering deleted the re-enable-fastmnn branch December 2, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants