Fix trycatch hanging #190
Merged
Fix trycatch hanging #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 65.77% 65.77%
=======================================
Files 19 19
Lines 1347 1347
=======================================
Hits 886 886
Misses 461 461
Continue to review full report at Codecov.
|
ivababukova
reviewed
Dec 1, 2021
.github/workflows/ci.yaml
Outdated
| @@ -231,7 +231,7 @@ jobs: | |||
| KUBERNETES_ENV="staging" | |||
| REPLICA_COUNT="0" | |||
| IMAGE_GLOB="${IMAGE_TAG/$GITHUB_SHA/*}" | |||
| MEMORY_REQUEST="4Gi" | |||
| MEMORY_REQUEST="16Gi" | |||
There was a problem hiding this comment.
do you still need this change? I assume it was added just for testing?
There was a problem hiding this comment.
Yes just for testing. I'll remove prior to merging (bolded in Conversation that this needs to happen before merge) in case you or someone else also wants to test
ivababukova
reviewed
Dec 1, 2021
ivababukova
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-1392
https://biomage.atlassian.net/browse/BIOMAGE-1556
Link to staging deployment URL
https://ui-alex-ui569-pipe190.scp-staging.biomage.net/
Links to any Pull Requests related to this
hms-dbmi-cellenics/ui#569
Anything else the reviewers should know about the changes here
--> RESTORE STAGING RAM BEFORE MERGE <--
Test data: https://drive.google.com/drive/u/1/folders/1ioY1k6Or_461NtbH60npiCJfy8DPgKs6
NOTE: hangs in productions, not in staging
Cause of issue: aryoda/tryCatchLog#68
Changes
Code changes
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing
To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?
Approvers
Just before merging:
unstagescript in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to stagingOptional