feat!: Switch to SIP-030 #403
Conversation
🦋 Changeset detectedLatest commit: 3c2c6a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| // TYPES | ||
|
|
||
| export type NetworkString = 'mainnet' | 'testnet' | 'regtest' | 'devnet' | string; |
There was a problem hiding this comment.
afaik typescript will not autocomplete this unless you use a LiteralUnion
There was a problem hiding this comment.
I'll try that. Thx
I did try the string literal union, but with string being a union member didn't work.
|
|
||
| /** Disconnect selected wallet. Alias for {@link clearSelectedProviderId} */ | ||
| export const disconnect = clearSelectedProviderId; | ||
|
|
||
| export { isProviderSelected } from '@stacks/connect-ui'; | ||
|
|
||
| /** | ||
| * @deprecated Use the renamed {@link showConnect} method |
There was a problem hiding this comment.
This should be updated as well.
There was a problem hiding this comment.
Which one do you mean? showBlockstack is an alias for showConnect which uses authenticate which mimics the new flow to get a minimum of address selection working in the UserSession. (To stay backwards compatible a bit, so it's easier for apps to update).
Marked as deprecated to indicate that this would be one of the methods that may disappear in another breaking release.
There was a problem hiding this comment.
I see, showConnect is not deprecated.
There was a problem hiding this comment.
That's a good point though, my thinking was I would mark these as deprecated as well. Where deprecated should mean, at some point they won't be updated anymore and we recommend an alternative way of doing things.
🚧 WIP
stx_signMessage)method,params, andresponsetypes.