feat(studio): give the clips on a track one automation lane row - #3214
Merged
Conversation
miga-heygen
reviewed
Aug 11, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Clean architecture. The per-track lane grouping is well-designed — SSOT in groupAutomationLanes, stable React keys via laneGroupKey, correct multi-clip SVG positioning.
No blocking issues.
How the key concerns are handled:
- Multi-clip resolution:
groupAutomationLanesunions by label. First clip fixes row index; later clips append new properties. Entries per group are in element order. - Overlapping clips: Each clip draws its own SVG at its own
leftPx/widthPx— overlapping visuals in the same row, correct for per-clip gestures. - Lane identity stability: React keys use
group.key(the label string), stable under selection changes. No remount/flicker. - SSOT: One lane per track is encoded in exactly one place (
groupAutomationLanes). All three call sites (header, slot, height) flow through it.
Non-blocking observations:
- Design record status is stale: says "Not yet implemented" but this PR IS the implementation.
groupAutomationLanesis computed independently at 3 sites without memoization. Cost is Map iteration (not parsing — attribute text is cached), acceptable for typical track sizes but auseMemoin the Slot component would help if many-clip tracks become common.laneGroupKeydelegates toautomationLaneLabel— the display label IS the React key. Elegant but means a label format change remounts every row. Documented and intentional.- The
holdingOpentrick inuseTimelineRowHeightsis well-commented. Safe today sincetrackHeightsonly usesclipIdfor theexpandedClipIds.has()check. - No test for clip deletion from a multi-clip track — grouping/height shrinkage after removal. May be covered by integration tests elsewhere.
LGTM.
Review by Miga
vanceingalls
force-pushed
the
wa-18h-shared-rows
branch
from
August 12, 2026 02:56
eea4dc2 to
ba5342b
Compare
vanceingalls
force-pushed
the
wa-18g-carve-module
branch
from
August 12, 2026 02:56
e3ef910 to
b8ae6b5
Compare
vanceingalls
force-pushed
the
wa-18h-shared-rows
branch
from
August 12, 2026 04:48
ba5342b to
48672b4
Compare
vanceingalls
force-pushed
the
wa-18g-carve-module
branch
from
August 12, 2026 04:48
b8ae6b5 to
9829dc3
Compare
vanceingalls
force-pushed
the
wa-18h-shared-rows
branch
from
August 12, 2026 07:26
48672b4 to
0caeeb4
Compare
vanceingalls
force-pushed
the
wa-18g-carve-module
branch
from
August 12, 2026 07:26
9829dc3 to
59a8531
Compare
vanceingalls
force-pushed
the
wa-18h-shared-rows
branch
from
August 12, 2026 07:49
0caeeb4 to
4692e39
Compare
vanceingalls
force-pushed
the
wa-18g-carve-module
branch
from
August 12, 2026 07:49
59a8531 to
4c03e3c
Compare
…tions guard build-audio-fx-runtime.ts and build-position-edits-render.ts were merged into build-inline-artifact.ts to kill a fallow duplication finding; the deletion guard flagged that as an accidental loss since main still has both originals.
Table column widths had drifted out of alignment with oxfmt's own rules, failing format:check and blocking the Preflight gate every downstream branch inherits. Whitespace only, no content change.
…psOverlap's negative duration \b treats `_` as a word character, so \bbed\b never matched bed_01, music_bed_loop, or theme_song, and \bvo\b/\bvox\b/\btts\b had the same gap — an underscore-separated bed classified as "unknown" and could end up offered as its own carve source. Replaced the short hints with a boundary that actually excludes letters and digits on both sides. clipsOverlap computed end = start + duration without guarding sign, so a negative duration put end before start — an interval that does not describe anything, and one specific case showed it silently dropping a real overlap (a shorter, earlier broken end rejected a clip that genuinely contained the point). Duration clamps to zero instead: a clip cannot un-play time, and a zero-length clip at its start is the sane reading of "duration nobody wrote down as positive." Review by Miga (PR #3212).
The 20s margin (already once widened for the same reason) is timing out in CI's full-monorepo Test run — the resetModules()+fresh-import render this test needs is uncached and competes with every other package's test suite for the same worker pool, and the same test passes in well under 2s standalone. Went to 45s rather than re-tuning to whatever number happens to clear the current CI load, since that number moves every time CI gains a package.
Two auto-apply effects both fire when sourceOptions.length === 1: the multi-candidate effect only guards length === 0, so a single candidate passes it too, and the single-candidate effect passes its own guard right after — both compute the same sources list and both call setCarve, so the common case (one narrator, one bed) triggered two decodes, two FFT runs, and two concurrent attribute writes for one decision. The multi-candidate effect now defers to its sibling for exactly one candidate, which already has its own detailed handling for that case. Review by Miga (PR #3213).
* feat(core): carve against every voice over a bed, always dynamically A bed usually runs under a whole sequence — a narrator, an interview answer, a second presenter — and carving against one of them left the others fighting it. `source` becomes `sources`, and `mixCarveSources` sums every voice onto the BED's clock before anything is measured. That is what keeps one analysis sufficient: the chain is fixed, so there is no per-voice filter to switch between, and bands drawn from all the speech there is with envelopes that rise wherever any of it happens answer the actual question — where and when is speech masking this bed. Summed rather than averaged: two people talking at once mask more than either alone. Audio before the bed starts is dropped rather than folded in at zero, since it plays over nothing and shifting it would put a cut where there is no voice. `dynamic` is gone. A fixed depth thins the bed through every pause, and once both have been heard there is no reason to want it, so every carve follows the speech. Two helpers the panel and the headless script now share instead of each carrying a copy — two definitions of "what does this name suggest" drift, and then the two disagree about which track is the voice: - `classifyAudioName` reads a track's kind from its id and filename together. `unknown` is deliberately common: treating an unrecognised name as "not a voice" would hide the one track somebody needs to pick. - `clipsOverlap` keeps out a voice that never plays while the bed does. An unwritten duration counts as unbounded, not zero — refusing a clip whose length the composition leaves to the media would drop the commonest case there is. Files written before this still load: a single `source` reads as a one-voice list, a stored `dynamic` is ignored, and an absent attribute means the defaults whole. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(core): stop \b from missing underscore-separated names, guard clipsOverlap's negative duration \b treats `_` as a word character, so \bbed\b never matched bed_01, music_bed_loop, or theme_song, and \bvo\b/\bvox\b/\btts\b had the same gap — an underscore-separated bed classified as "unknown" and could end up offered as its own carve source. Replaced the short hints with a boundary that actually excludes letters and digits on both sides. clipsOverlap computed end = start + duration without guarding sign, so a negative duration put end before start — an interval that does not describe anything, and one specific case showed it silently dropping a real overlap (a shorter, earlier broken end rejected a clip that genuinely contained the point). Duration clamps to zero instead: a clip cannot un-play time, and a zero-length clip at its start is the sane reading of "duration nobody wrote down as positive." Review by Miga (PR #3212). --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
#3212 (accidentally squash-merged into this branch instead of main) changed HfCarveSettings from a single `source` + `dynamic` toggle to a `sources` list with dynamic mode removed outright — the multi-voice UI consumer that goes with that shape lands in the very next PR, so this branch was left with a type that no longer matched its own code. Minimal port, not the multi-voice redesign that PR does properly: the "Listen to" picker and analyse() treat sources[0] as the one voice this UI still understands, and every dynamic-mode branch (the automated envelope lanes, the toggle, the checkbox) is gone along with the field — a carve is now always the static value the analysis computes, matching what the type change made permanent. Test suite trimmed the same way: the automation-lane and toggle tests covered behavior that no longer exists.
# Conflicts: # packages/studio/src/components/editor/propertyPanelAudioFxGroup.test.tsx # packages/studio/src/components/editor/propertyPanelAudioFxGroup.tsx # packages/studio/src/components/editor/propertyPanelFxSection.tsx
# Conflicts: # packages/studio/src/components/editor/propertyPanelAudioFxGroup.test.tsx # packages/studio/src/components/editor/propertyPanelAudioFxGroup.tsx # packages/studio/src/components/editor/propertyPanelFxSection.tsx # skills-manifest.json # skills/hyperframes-audio/SKILL.md # skills/hyperframes-audio/references/attributes.md # skills/hyperframes-audio/scripts/carve.mjs
Fallow audit reportFound 3 findings. Duplication (2)
Health (1)
Generated by fallow. |
vanceingalls
added a commit
that referenced
this pull request
Aug 13, 2026
Fixes a pre-existing aria-owns mismatch surfaced by the merge: the property-lane header cell used the combined caret id (clip lanes + track automation lanes) while the row wrapper's aria-owns still used the single un-combined id, so they never matched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every clip on a track shares one automation lane row, rather than each clip growing its own. A track has one volume, and a row per clip made that look like several.
Includes the design record for why effects stay on the clip while lanes belong to the track.
🤖 Generated with Claude Code