Skip to content

Conversation

@thyming
Copy link
Contributor

@thyming thyming commented Jan 15, 2026

Closes #3208

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2026

🦋 Changeset detected

Latest commit: 57334d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 15, 2026

@thyming is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. feature 🚀 Feature request. labels Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 1.45349% with 339 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.22%. Comparing base (1a98f23) to head (57334d8).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/plugins/zod/mini/toAst/enum.ts 1.11% 89 Missing ⚠️
...ckages/openapi-ts/src/plugins/zod/v4/toAst/enum.ts 1.11% 89 Missing ⚠️
...ckages/openapi-ts/src/plugins/zod/v3/toAst/enum.ts 1.16% 85 Missing ⚠️
...es/openapi-ts/src/plugins/valibot/v1/toAst/enum.ts 2.56% 76 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3209      +/-   ##
==========================================
- Coverage   33.47%   33.22%   -0.25%     
==========================================
  Files         451      451              
  Lines       34496    34752     +256     
  Branches     2244     2244              
==========================================
+ Hits        11547    11548       +1     
- Misses      22919    23174     +255     
  Partials       30       30              
Flag Coverage Δ
unittests 33.22% <1.45%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 15, 2026

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@3209
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@3209
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@3209
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@3209

commit: d4b5f87

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a quality pull request – thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 16, 2026
@mrlubos mrlubos merged commit 4213072 into hey-api:main Jan 16, 2026
10 of 11 checks passed
@hey-api hey-api bot mentioned this pull request Jan 16, 2026
@thyming thyming deleted the add-enum-resolver-support branch January 16, 2026 04:24
@helmoski
Copy link

Thank you for your quick review and action on this @mrlubos, and thank you @thyming for the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature 🚀 Feature request. lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enum Resolver

3 participants