-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up themes & plugins #1941
Conversation
Theme name validation passed. |
There are at least 70 theme preview links that need to be updated. Using git to manage this content is also not very convenient, perhaps we can use an object storage like cloudflare r2 CC @hexojs/core |
Instead of using |
Good idea. But how to update them automatically? They will be updated many times. But I assume many of the theme authors will not update after merging first-time PR. |
How about using GitHub Actions? Every time when the author updates the theme, the GitHub Actions will be triggered to build the demo site with hexo-theme-unit-test, then submit the content to a Git repository in hexojs, or to a cloud storage. We can also use this to infer when the theme was last updated, and whether it is compatible with the latest Hexo |
Sorry, I can't image this. I don't know how to detect a theme has changed even if we use GitHub Action. So, is it means theme authors have to add GitHub Actions to their repositories and send a notification to us in some way? |
@yoshinorin Yes, theme authors need to add github actions scripts to their theme repositories, to automatically build the site with hexo-theme-unit-test when new commits are pushed, and submit the demo sites to the cloud storage or git repository provided by hexo. There will be some security and access control issues that will need to be discussed further. |
Ok. Understand. I think it is worth trying that :) |
P.S How about polling registered repositories?
Pros: Cons: |
Check List
Please read and check followings before submitting a PR.
name
is unique.link
URL is correct.preview
URL is correct.preview
URL web site is rendered correctly.source/themes/screenshots
.name
.800 * 500
.png
.name
is unique.link
URL is correct.en
Englishru
Russianzh-cn
simplified Chinesezh-tw
traditional ChineseSee #1473
Pending #1600 (comment)
See also #1429