Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-1.x] fix: falsely omitted fields in firewall schema #404

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[Backport release-1.x] fix: falsely omitted fields in firewall schema #404

merged 1 commit into from
Apr 11, 2024

Commits on Apr 11, 2024

  1. fix: falsely omitted fields in firewall schema (#396) 

    In the [API Docs](https://docs.hetzner.cloud/#firewalls-get-a-firewall)
the `description`, `port`, `destination_ips` and `source_ips` properties
are not marked as required (thus being optional) although in practice
they are always set. This leads to inconsistencies between marshaled
schemas and API responses. This PR modifies the schema so that it is
consistent with the actual API output.

(cherry picked from commit a3509b6)
    @phm07 @github-actions
    phm07 authored and github-actions[bot] committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7190730 View commit details
    Browse the repository at this point in the history