[Backport release-1.x] fix: falsely omitted fields in firewall schema #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
In the [API Docs](https://docs.hetzner.cloud/#firewalls-get-a-firewall) the `description`, `port`, `destination_ips` and `source_ips` properties are not marked as required (thus being optional) although in practice they are always set. This leads to inconsistencies between marshaled schemas and API responses. This PR modifies the schema so that it is consistent with the actual API output. (cherry picked from commit a3509b6)
apricote
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a3509b6 from #396.
BEGIN_COMMIT_OVERRIDE
fix: falsely omitted fields in firewall schema
END_COMMIT_OVERRIDE