fix(firewall): wrong wording when firewall is removed from resource #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
approved these changes
Jul 10, 2024
phm07
force-pushed
the
fix-firewall-remove-wording
branch
from
f4fb928
to
3580576
Compare
|
I reworded it again because |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
=======================================
Coverage 59.60% 59.60%
=======================================
Files 210 210
Lines 7655 7655
=======================================
Hits 4563 4563
Misses 2450 2450
Partials 642 642 ☔ View full report in Codecov by Sentry. |
jooola
approved these changes
Jul 10, 2024
jooola
reviewed
Jul 10, 2024
| @@ -43,7 +43,7 @@ func TestApplyToServer(t *testing.T) { | |||
|
|
|||
| out, errOut, err := fx.Run(cmd, []string{"--type", "server", "--server", "my-server", "test"}) | |||
|
|
|||
| expOut := "Firewall 123 applied\n" | |||
| expOut := "Firewall 123 applied to resource\n" | |||
There was a problem hiding this comment.
We might target many resources when using the label selector, but I think this is good enough.
There was a problem hiding this comment.
We could also add special messages like Firewall 123 applied to label selector xyz
apricote
pushed a commit
that referenced
this pull request
Jul 17, 2024
🤖 I have created a release *beep* *boop* --- ## [1.45.0](v1.44.2...v1.45.0) (2024-07-17) ### Features * allow configuring default sort columns for each supported resource ([#795](#795)) ([f6877a1](f6877a1)) * better error messages on malformed option value ([#798](#798)) ([8c6fec9](8c6fec9)) ### Bug Fixes * **config:** ordering of list option values not preserved ([#805](#805)) ([1ac27bf](1ac27bf)) * debug log is truncated if it already exists ([#793](#793)) ([c3d3a9f](c3d3a9f)) * **firewall:** wrong wording when firewall is removed from resource ([#812](#812)) ([9017a65](9017a65)), closes [#809](#809) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #809