Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wording when a firewall is removed from resource is wrong #809

Closed
jooola opened this issue Jul 5, 2024 · 0 comments · Fixed by #812 or #804
Closed

Wording when a firewall is removed from resource is wrong #809

jooola opened this issue Jul 5, 2024 · 0 comments · Fixed by #812 or #804
Labels
bug

Comments

@jooola
Copy link
Member

jooola commented Jul 5, 2024

TL;DR

The wording when removing a firewall from a resource is wrong.

Expected behavior

The wording should match the result of the action that was taken.

Observed behavior

cli/internal/cmd/firewall/remove_from_resource.go

Line 86 in 1ac27bf

cmd.Printf("Firewall %d applied\n", firewall.ID)

Minimal working example

No response

Log output

No response

Additional information

No response
@jooola jooola added the bug label Jul 5, 2024
@jooola jooola changed the title Working when a firewall is removed from resource is wrong Wording when a firewall is removed from resource is wrong Jul 5, 2024
@phm07 phm07 mentioned this issue Jul 10, 2024
Merged
@phm07 phm07 closed this as completed in 9017a65 Jul 10, 2024
@hcloud-bot hcloud-bot mentioned this issue Jul 10, 2024
Merged
apricote pushed a commit that referenced this issue Jul 17, 2024
@hcloud-bot
chore(main): release 1.45.0 (#804)
072a219 
🤖 I have created a release *beep* *boop*
---


##
[1.45.0](v1.44.2...v1.45.0)
(2024-07-17)


### Features

* allow configuring default sort columns for each supported resource
([#795](#795))
([f6877a1](f6877a1))
* better error messages on malformed option value
([#798](#798))
([8c6fec9](8c6fec9))


### Bug Fixes

* **config:** ordering of list option values not preserved
([#805](#805))
([1ac27bf](1ac27bf))
* debug log is truncated if it already exists
([#793](#793))
([c3d3a9f](c3d3a9f))
* **firewall:** wrong wording when firewall is removed from resource
([#812](#812))
([9017a65](9017a65)),
closes [#809](#809)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@BrewTestBot BrewTestBot mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@jooola