Skip to content

feat(toast): fix-toast-animation#5929

Closed
hassanzadeh-mj wants to merge 1 commit into
heroui-inc:canaryfrom
hassanzadeh-mj:fix/toast-animation
Closed

feat(toast): fix-toast-animation#5929
hassanzadeh-mj wants to merge 1 commit into
heroui-inc:canaryfrom
hassanzadeh-mj:fix/toast-animation

Conversation

@hassanzadeh-mj
Copy link
Copy Markdown

@hassanzadeh-mj hassanzadeh-mj commented Nov 23, 2025

Closes #

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Documentation
    • Added new documentation section with example code demonstrating how to disable animations in toast notifications.

✏️ Tip: You can customize this high-level summary in your review settings.

- Add disable-animation example to docs
- Resolves duplicate toast and animation speed issues
- Fixes heroui-inc#5883
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 23, 2025

@hassanzadeh-mj is attempting to deploy a commit to the HeroUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 23, 2025

⚠️ No Changeset found

Latest commit: 492acaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 23, 2025

Walkthrough

This pull request adds documentation and example code demonstrating how to disable toast animations. A new demo component with accompanying TypeScript module exports the example, integrated into the toast documentation via an index update and new documentation section.

Changes

Cohort / File(s) Summary
Toast disable-animation demo
apps/docs/content/components/toast/disable-animation.raw.jsx, apps/docs/content/components/toast/disable-animation.ts
New demo component showing how to use disableAnimation={true} on ToastProvider; includes TypeScript module re-exporting the raw JSX resource with standard documentation file mapping.
Toast exports
apps/docs/content/components/toast/index.ts
Added disableAnimation property to the exported toastContent object to include the new demo in the component documentation structure.
Toast documentation
apps/docs/content/docs/components/toast.mdx
Added new section explaining how to disable toast animations with disableAnimation={true} on ToastProvider, including CodeDemo block referencing the new demo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • The changes consist primarily of documentation and example code boilerplate following established patterns
  • The new JSX demo is a straightforward functional component with minimal logic
  • The TypeScript module follows standard documentation structure conventions
  • Index and documentation updates are simple additions

Possibly related PRs

Suggested reviewers

  • jrgarciadev
  • wingkwong

Pre-merge checks and finishing touches

❌ Failed checks (3 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. While it mentions fixing issue #5883 and adding a disable-animation example, most template sections (Description, Current behavior, New behavior, Breaking change, Additional Information) remain as unfilled placeholders. Complete the PR description by filling in the template sections with details about what was added, the current behavior being addressed, and the new behavior enabled by these changes.
Linked Issues check ⚠️ Warning The PR addresses only one of the three main objectives from issue #5883: it provides an example for disabling animations. However, it does not implement the core bug fixes for duplicate toasts or improve animation speed performance. Either implement code changes to fix duplicate toast elements and improve animation speed as required by issue #5883, or clarify that this PR only provides documentation guidance and a separate PR will address the core bugs.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The PR title 'feat(toast): fix-toast-animation' is vague and generic, using 'fix' without clearly conveying what animation issue is being addressed or that documentation examples are being added. Use a more descriptive title like 'feat(toast): add disable-animation example to documentation' to clearly indicate the primary change.
✅ Passed checks (1 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed All changes are directly related to adding a disable-animation example to the toast documentation, which aligns with the stated PR objective.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hassanzadeh-mj hassanzadeh-mj changed the title feat(toast): add example for disabling toast animations in documentation feat(toast): fix-toast-animation Nov 23, 2025
Copy link
Copy Markdown
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reported issue is

When you close a toast, duplicates still appear in the background, even if there's only one element to duplicate.

In storybook, it works even with animation. Hence, your PR basically doesn't solve anything.

@wingkwong
Copy link
Copy Markdown
Member

Lemme take over this issue.

@wingkwong wingkwong closed this Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Toast bugs. Dublicating toast, animation speed etc

2 participants