feat(toast): fix-toast-animation#5929
Conversation
- Add disable-animation example to docs - Resolves duplicate toast and animation speed issues - Fixes heroui-inc#5883
|
@hassanzadeh-mj is attempting to deploy a commit to the HeroUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
|
WalkthroughThis pull request adds documentation and example code demonstrating how to disable toast animations. A new demo component with accompanying TypeScript module exports the example, integrated into the toast documentation via an index update and new documentation section. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (3 warnings, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wingkwong
left a comment
There was a problem hiding this comment.
The reported issue is
When you close a toast, duplicates still appear in the background, even if there's only one element to duplicate.
In storybook, it works even with animation. Hence, your PR basically doesn't solve anything.
|
Lemme take over this issue. |
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.