Skip to content

fix(heroui-table): update virtualization examples to use @heroui/reac…#5833

Merged
jrgarciadev merged 1 commit into
heroui-inc:canaryfrom
nikhil-304:update/virtualization-imports
Oct 21, 2025
Merged

fix(heroui-table): update virtualization examples to use @heroui/reac…#5833
jrgarciadev merged 1 commit into
heroui-inc:canaryfrom
nikhil-304:update/virtualization-imports

Conversation

@nikhil-304
Copy link
Copy Markdown

@nikhil-304 nikhil-304 commented Oct 20, 2025

Closes #5832

📝 Description

This pull request updates the imports of virtualization components. Previously, the components were incorrectly importing from @nextui-org/react. All imports have now been updated to @heroui/react to align with the current HeroUI package structure. This ensures consistency and resolves potential issues caused by incorrect imports.

⛳️ Current behavior (updates)

Before the fix, virtualization components were importing from @nextui-org/react, which could cause unexpected behavior or errors.

Before:
Before fixing imports

🚀 New behavior

After this fix, all virtualization components correctly import from @heroui/react, ensuring proper functionality and consistency across the project.

After:
After fixing imports

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

No additional information. Images above illustrate the issue and the resolved state.

Summary by CodeRabbit

  • Chores
    • Updated documentation examples for table virtualization features across multiple sample files to align with current library dependencies. All component functionality, rendering logic, and demonstrated capabilities remain identical. Examples continue to accurately showcase table virtualization configuration options and performance patterns without changes to actual behavior or component usage.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 20, 2025

⚠️ No Changeset found

Latest commit: 69170d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 20, 2025

Walkthrough

Four table virtualization example files in the documentation are updated to import components from @heroui/react instead of @nextui-org/react, correcting import paths to match the public HeroUI package structure without altering component logic or behavior.

Changes

Cohort / File(s) Summary
Table Virtualization Examples
apps/docs/content/components/table/virtualization.raw.jsx, apps/docs/content/components/table/virtualization-custom-max-table-height.raw.jsx, apps/docs/content/components/table/virtualization-custom-row-height.raw.jsx, apps/docs/content/components/table/virtualization-ten-thousand.raw.jsx
Updated import source from @nextui-org/react to @heroui/react for Table components; no changes to component usage, rendering logic, or virtualization configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Rationale: All changes are repetitive, homogeneous import statement replacements across four files with no logic modifications or behavioral changes.

Suggested reviewers

  • jrgarciadev
  • wingkwong

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "fix(heroui-table): update virtualization examples to use @heroui/react" accurately summarizes the main change in the changeset. It clearly indicates that virtualization example files are being updated to use the correct import source (@heroui/react instead of @nextui-org/react), using the conventional "fix" prefix appropriate for bug corrections. The title is specific enough that a teammate scanning history would understand the primary change without needing to inspect individual file modifications.
Linked Issues Check ✅ Passed The PR directly addresses all coding-related objectives from issue #5832. It fixes the import errors by updating all virtualization example files from @nextui-org/react to @heroui/react, ensuring the examples use only public, resolvable packages. This change resolves the "Module not found: Can't resolve '@nextui-org/react'" error and makes the examples work consistently in local React + TypeScript projects, matching their behavior in the docs preview. The component interfaces and usage logic remain unchanged, only the import source is corrected.
Out of Scope Changes Check ✅ Passed All changes in the PR are directly within scope of the linked issue #5832. The four modified files (virtualization.raw.jsx, virtualization-custom-max-table-height.raw.jsx, virtualization-custom-row-height.raw.jsx, and virtualization-ten-thousand.raw.jsx) all contain only import source updates from @nextui-org/react to @heroui/react with no additional modifications, refactoring, or unrelated changes. Each file alteration directly addresses the import error described in the linked issue without introducing any extraneous changes.
Description Check ✅ Passed The PR description fully adheres to the repository template, including all required sections: Closes #5832, Description, Current behavior (updates), New behavior, Is this a breaking change, and Additional Information. Each section is properly filled with meaningful content, including a clear explanation of the import changes, before/after screenshots demonstrating the issue and resolution, and explicit confirmation that this is not a breaking change. The description provides sufficient context for reviewers to understand the problem being solved and the fix being applied.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2922b35 and 69170d8.

📒 Files selected for processing (4)
  • apps/docs/content/components/table/virtualization-custom-max-table-height.raw.jsx (1 hunks)
  • apps/docs/content/components/table/virtualization-custom-row-height.raw.jsx (1 hunks)
  • apps/docs/content/components/table/virtualization-ten-thousand.raw.jsx (1 hunks)
  • apps/docs/content/components/table/virtualization.raw.jsx (1 hunks)
🔇 Additional comments (4)
apps/docs/content/components/table/virtualization-custom-row-height.raw.jsx (1)

1-1: Import path corrected to resolve module resolution errors.

The change from @nextui-org/react to @heroui/react is correct and fixes the import error reported in issue #5832. This aligns with the current HeroUI package structure and ensures the example works when copied to local projects.

apps/docs/content/components/table/virtualization-ten-thousand.raw.jsx (1)

1-1: Import path corrected.

Consistent with the other virtualization examples, this import fix ensures the example is functional when used in local projects.

apps/docs/content/components/table/virtualization.raw.jsx (1)

1-1: Import path corrected.

The change correctly updates the import to use the public @heroui/react package.

apps/docs/content/components/table/virtualization-custom-max-table-height.raw.jsx (1)

1-1: All import corrections verified and complete.

The verification confirms that no component examples in apps/docs/content/components/ retain the old @nextui-org/react imports. References to the old package name only appear in:

  • Migration guide (nextui-to-heroui.mdx) — intentional documentation of the upgrade path
  • Blog post (introducing-heroui.mdx) — historical context

The import correction for this file (and all other table virtualization examples) is correct and no further action is needed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 15, 2026

Deployment failed with the following error:

Creating the Deployment Timed Out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Table Virtualization Local import code fails in React + TypeScript app while website preview works fine

2 participants