chore: bump tailwind-variants version#5634
Conversation
🦋 Changeset detectedLatest commit: 86df653 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughBumps Changes
Sequence Diagram(s)(No sequence diagram; changes are dependency/version updates and do not modify runtime control flow.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
@heroui/accordion
@heroui/alert
@heroui/autocomplete
@heroui/avatar
@heroui/badge
@heroui/breadcrumbs
@heroui/button
@heroui/calendar
@heroui/card
@heroui/checkbox
@heroui/chip
@heroui/code
@heroui/date-input
@heroui/date-picker
@heroui/divider
@heroui/drawer
@heroui/dropdown
@heroui/form
@heroui/image
@heroui/input
@heroui/input-otp
@heroui/kbd
@heroui/link
@heroui/listbox
@heroui/menu
@heroui/modal
@heroui/navbar
@heroui/number-input
@heroui/pagination
@heroui/popover
@heroui/progress
@heroui/radio
@heroui/ripple
@heroui/scroll-shadow
@heroui/select
@heroui/skeleton
@heroui/slider
@heroui/snippet
@heroui/spacer
@heroui/spinner
@heroui/switch
@heroui/table
@heroui/tabs
@heroui/toast
@heroui/tooltip
@heroui/user
@heroui/react
@heroui/system
@heroui/system-rsc
@heroui/theme
@heroui/use-aria-accordion
@heroui/use-aria-accordion-item
@heroui/use-aria-button
@heroui/use-aria-link
@heroui/use-aria-modal-overlay
@heroui/use-aria-multiselect
@heroui/use-aria-overlay
@heroui/use-callback-ref
@heroui/use-clipboard
@heroui/use-data-scroll-overflow
@heroui/use-disclosure
@heroui/use-draggable
@heroui/use-form-reset
@heroui/use-image
@heroui/use-infinite-scroll
@heroui/use-intersection-observer
@heroui/use-is-mobile
@heroui/use-is-mounted
@heroui/use-measure
@heroui/use-pagination
@heroui/use-real-shape
@heroui/use-ref-state
@heroui/use-resize
@heroui/use-safe-layout-effect
@heroui/use-scroll-position
@heroui/use-ssr
@heroui/use-theme
@heroui/use-update-effect
@heroui/use-viewport-size
@heroui/aria-utils
@heroui/dom-animation
@heroui/framer-utils
@heroui/react-rsc-utils
@heroui/react-utils
@heroui/shared-icons
@heroui/shared-utils
@heroui/stories-utils
@heroui/test-utils
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/wet-tigers-argue.md (1)
1-7: Add a brief rationale to the changeset for future readers.Consider noting that this is an internal dependency bump with no public API changes, and that it aligns with Tailwind CSS v4 + tailwind-merge v3 in the repo. Optional, but helps future archaeology.
Suggested tweak:
--- "@heroui/system-rsc": patch "@heroui/theme": patch --- -chore: bump tailwind-variants version +chore: bump tailwind-variants to 3.0.0 + +Internal dependency update only (no public API changes). Aligns packages with Tailwind CSS v4 and tailwind-merge v3 used in the monorepo.apps/docs/package.json (1)
84-84: Docs dep bump is fine; consider semver range if you want to pick up patch fixes automatically.Pinning to
3.0.0is acceptable for reproducibility. If you prefer to auto-receive patch updates fromtailwind-variantsin the docs app, switch to^3.0.0. Totally optional—follow the repo’s prevailing convention.Optional diff:
- "tailwind-variants": "3.0.0", + "tailwind-variants": "^3.0.0",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
.changeset/wet-tigers-argue.md(1 hunks)apps/docs/package.json(1 hunks)packages/core/system-rsc/package.json(1 hunks)packages/core/theme/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Prettier
- GitHub Check: TypeScript
- GitHub Check: Continuous Release
- GitHub Check: Tests
- GitHub Check: ESLint
- GitHub Check: Build
🔇 Additional comments (3)
packages/core/system-rsc/package.json (1)
45-45: Verified: No runtime imports of tailwind-variants; devDependency is safeThe only reference to “tailwind-variants” is an
import typein extend-variants.d.ts, which is stripped out at compile time. No runtimeimportorrequirecalls were found in source or (nonexistent) build output.apps/docs/package.json (1)
84-84: No breaking changes in docs’ tv() usage after upgrading to tailwind-variants v3All grep’d
tv()calls inapps/docsuse only the supported options (base,variants,slots,extend) and import the default build oftv(which retains fulltailwind-mergebehavior). Tailwind-variants v3’s only breaking change is the introduction of a separate “lite” entrypoint that drops merge-config support—examples importing from"tailwind-variants"without a second-argument config remain fully compatible. (github.com)packages/core/theme/package.json (1)
54-54: ✅ Dependency bump to tailwind-variants@3.0.0 verified
- Peer dependencies for tailwind-variants@3.0.0 include
tailwind-merge: ">=3.0.0"andtailwindcss: "*", and the theme package pinstailwind-mergeto3.3.1, satisfying this requirement.- No runtime calls to
tv()were found inpackages/core/theme/src; only type imports and thetvwrapper inutils/tv.tsreference it.- The custom
tvwrapper’s signature and defaulttwMergeconfiguration align with the v3 API, so the public theme API remains unchanged.All checks pass—no further action needed.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/storybook/package.json (1)
12-16: Fix broken entry points inpackages/storybook/package.jsonThe
mainfield currently points tosrc/index.ts, but thefilesarray only includesdist. As a result, consumers installing the published package won’t receive the source file and will encounter a missing entry point.• File needing update:
packages/storybook/package.json(around lines 12–16)Apply the following changes to align your exports with the built outputs:
- "main": "src/index.ts", + "main": "dist/index.js", + "module": "dist/index.mjs", + "types": "dist/index.d.ts", + "exports": { + ".": { + "types": "./dist/index.d.ts", + "import": "./dist/index.mjs", + "require": "./dist/index.js" + } + },If this package is intended for internal/storybook-only use and shouldn’t be published, consider adding
"private": trueinstead to prevent accidental publishes.
🧹 Nitpick comments (1)
packages/storybook/package.json (1)
20-24: Repository.directory path appears incorrectThis file lives at
packages/storybook/package.json, butrepository.directorypoints topackages/components/storybook. This breaks npm repo links and source mapping on package registries.Proposed fix:
- "directory": "packages/components/storybook" + "directory": "packages/storybook"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
.changeset/chilly-garlics-lick.md(1 hunks)apps/docs/components/sandpack/use-sandpack.ts(1 hunks)apps/docs/package.json(3 hunks)packages/core/theme/package.json(2 hunks)packages/storybook/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- apps/docs/components/sandpack/use-sandpack.ts
- .changeset/chilly-garlics-lick.md
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/docs/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Continuous Release
- GitHub Check: Build
- GitHub Check: TypeScript
🔇 Additional comments (2)
packages/core/theme/package.json (2)
54-56: Confirm tailwind-variants@3.0.0 compatibilityThis upgrade is a semver-major bump—
tailwind-variants@3.0.0may remove or rename APIs or change TypeScript signatures. In our theme package, you can see:
- Imports from
"tailwind-variants"in
• packages/core/theme/src/utils/tv.ts (both type TV andtv as tvBase)
• packages/core/theme/src/utils/types.ts (type ClassValue)
• packages/core/theme/src/index.ts (re-exportingtvandVariantProps)
• And type imports ofVariantPropsin every component file undersrc/components- Direct calls to
tv({ … })(and use ofextend/composein a few places) in all ~50 component definitions underpackages/core/theme/src/componentsPlease:
- Run a full TypeScript type-check (
yarn workspace @heroui/theme tsc --noEmit) and resolve any errors.- Spot-check critical components (e.g.,
button,modal,dropdown) in Storybook or locally to catch any runtime styling regressions.- Review the tailwind-variants 3.0.0 changelog for any removed/renamed options or typing changes that affect
slots,variants,compoundVariants,extend/compose, etc.If you’d prefer to receive future patch releases automatically, consider loosening to a caret range:
- "tailwind-variants": "3.0.0", + "tailwind-variants": "^3.0.0",Otherwise, pinning to exactly
3.0.0is fine for full determinism.
62-66: Ensure Node engine compatibility after Tailwind v4 bumpI’ve verified that there are no legacy
tailwind.config.*files inpackages/core/themeand that your build scripts (tsup) do not invoketailwindcssdirectly. However, the package’spackage.jsondoes not declare any"engines"field to pin a Node version, which is important because Tailwind v4 has a minimum Node requirement.• No
tailwind.config.*files found underpackages/core/theme
• Build scripts inpackage.json("build","build:fast","dev") do not referencetailwindcss
•packages/core/theme/package.jsonis missing an"engines": { "node": "…" }declarationPlease confirm that your development and CI environments are running a Node version that satisfies Tailwind v4’s requirements, and consider adding an appropriate
"engines.node"entry (e.g."node": ">=16.8.0") topackages/core/theme/package.json.
| "tailwindcss": "4.1.12", | ||
| "vite": "^5.4.11", | ||
| "@tailwindcss/postcss": "4.1.11", | ||
| "@tailwindcss/vite": "4.1.11" | ||
| "@tailwindcss/postcss": "4.1.12", | ||
| "@tailwindcss/vite": "4.1.12" | ||
| }, |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Tailwind v4.1.12 bump: check Storybook/Vite plugin wiring and workspace consistency
The version bumps look correct. Please verify:
- Storybook’s Vite config imports and uses
@tailwindcss/vite(not legacytailwindcssplugin). - There are no lingering
tailwind.config.{js,ts}files in this package; Tailwind v4 uses the PostCSS plugin (@tailwindcss/postcss) and the new content discovery. - All workspace packages pin Tailwind-related devDeps to the same 4.1.12 to avoid transitive mismatches.
Run the following to confirm plugin usage and version alignment:
If you want to make the versions resilient to patch updates, consider caret ranges:
- "tailwindcss": "4.1.12",
+ "tailwindcss": "^4.1.12",
- "@tailwindcss/postcss": "4.1.12",
+ "@tailwindcss/postcss": "^4.1.12",
- "@tailwindcss/vite": "4.1.12"
+ "@tailwindcss/vite": "^4.1.12"🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) Check for legacy Tailwind config files (should be none under packages/storybook):"
fd -H -a -t f -g 'tailwind.config.*' packages/storybook || true
echo -e "\n2) Search for @tailwindcss/vite usage (should be present in Vite config used by Storybook):"
rg -nP '@tailwindcss/vite|tailwindcss/vite' -C2 -- packages || true
echo -e "\n3) Print Tailwind versions across the monorepo to ensure consistency:"
fd -H -a -t f -g package.json | xargs -I{} jq -r '.name + " :: " + (.devDependencies.tailwindcss // .dependencies.tailwindcss // "—")' {} | rg -n 'heroui|docs|storybook|theme|system|—'Length of output: 4003
Tailwind v4.1.12 bump: remove legacy config file, plugin wiring correct, versions aligned
- Legacy Tailwind config detected at
packages/storybook/tailwind.config.js– please remove this outdated file. - Vite config in
packages/storybook/vite.config.tscorrectly imports and uses@tailwindcss/vite. - Tailwind CSS is consistently pinned to
4.1.12in all relevant workspace packages (@heroui/docs,@heroui/theme,@heroui/storybook); no mismatches found.
Optional: to allow patch upgrades without manual bumps, consider switching to caret ranges:
- "tailwindcss": "4.1.12",
+ "tailwindcss": "^4.1.12",
- "@tailwindcss/postcss": "4.1.12",
+ "@tailwindcss/postcss": "^4.1.12",
- "@tailwindcss/vite": "4.1.12"
+ "@tailwindcss/vite": "^4.1.12"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "tailwindcss": "4.1.12", | |
| "vite": "^5.4.11", | |
| "@tailwindcss/postcss": "4.1.11", | |
| "@tailwindcss/vite": "4.1.11" | |
| "@tailwindcss/postcss": "4.1.12", | |
| "@tailwindcss/vite": "4.1.12" | |
| }, | |
| "tailwindcss": "^4.1.12", | |
| "vite": "^5.4.11", | |
| "@tailwindcss/postcss": "^4.1.12", | |
| "@tailwindcss/vite": "^4.1.12" | |
| }, |
🤖 Prompt for AI Agents
In packages/storybook/package.json around lines 54 to 58, a legacy Tailwind v3
config file packages/storybook/tailwind.config.js remains and should be removed;
delete that file from the repository and remove any direct imports or references
to it (search the package for require/import or build references) so the new
@tailwindcss/vite-based setup in packages/storybook/vite.config.ts is the sole
Tailwind config path, then run a quick local build or Storybook start to confirm
no config-resolution errors.
1 participant
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit