fix(button): icon focus behaviour on click

[wingkwong]

Closes #5200

📝 Description

Currently clicking icon in button will make it show the focus ring which is not expected.

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

[linear]

ENG-2423 [BUG] - Clicking icon in button leaves highlight

[changeset-bot]

🦋 Changeset detected

Latest commit: ff17098

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@heroui/button	Patch
@heroui/alert	Patch
@heroui/autocomplete	Patch
@heroui/calendar	Patch
@heroui/date-picker	Patch
@heroui/dropdown	Patch
@heroui/number-input	Patch
@heroui/popover	Patch
@heroui/select	Patch
@heroui/snippet	Patch
@heroui/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
heroui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 16, 2025 4:10pm
heroui-sb	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 16, 2025 4:10pm

[coderabbitai]

Walkthrough

A patch changeset was added for the @heroui/button package to address a UI issue related to icon focus behavior within buttons. The core code change modifies the useButton hook by removing the tabIndex: -1 attribute from cloned icon elements, while retaining the aria-hidden and focusable attributes. There are no changes to the public API or exports.

Changes

File(s)	Change Summary
.changeset/lazy-camels-clap.md	Added a changeset describing a patch update for @heroui/button to fix button icon focus issue.
packages/components/button/src/use-button.ts	Removed tabIndex: -1 from cloned icon elements in useButton hook.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Button
    participant Icon

    User->>Button: Clicks on icon within button
    Button->>Icon: Renders icon (without tabIndex: -1)
    Note right of Icon: Icon is not focusable via tabIndex
    User->>Button: Button receives focus as expected

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Fix button icon focus highlight when clicking icon (Issue #5200)	✅

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b865356 and ff17098.

📒 Files selected for processing (2)

• .changeset/lazy-camels-clap.md (1 hunks)
• packages/components/button/src/use-button.ts (0 hunks)

💤 Files with no reviewable changes (1)

• packages/components/button/src/use-button.ts

🔇 Additional comments (1)

.changeset/lazy-camels-clap.md (1)

1-6: Changeset summary is clear and sufficient.

The changeset accurately describes the patch and references the relevant issue. No further action needed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

Open in StackBlitz

@heroui/accordion

npm i https://pkg.pr.new/@heroui/accordion@5209

@heroui/alert

npm i https://pkg.pr.new/@heroui/alert@5209

@heroui/autocomplete

npm i https://pkg.pr.new/@heroui/autocomplete@5209

@heroui/avatar

npm i https://pkg.pr.new/@heroui/avatar@5209

@heroui/badge

npm i https://pkg.pr.new/@heroui/badge@5209

@heroui/breadcrumbs

npm i https://pkg.pr.new/@heroui/breadcrumbs@5209

@heroui/button

npm i https://pkg.pr.new/@heroui/button@5209

@heroui/calendar

npm i https://pkg.pr.new/@heroui/calendar@5209

@heroui/card

npm i https://pkg.pr.new/@heroui/card@5209

@heroui/checkbox

npm i https://pkg.pr.new/@heroui/checkbox@5209

@heroui/chip

npm i https://pkg.pr.new/@heroui/chip@5209

@heroui/code

npm i https://pkg.pr.new/@heroui/code@5209

@heroui/date-input

npm i https://pkg.pr.new/@heroui/date-input@5209

@heroui/date-picker

npm i https://pkg.pr.new/@heroui/date-picker@5209

@heroui/divider

npm i https://pkg.pr.new/@heroui/divider@5209

@heroui/drawer

npm i https://pkg.pr.new/@heroui/drawer@5209

@heroui/dropdown

npm i https://pkg.pr.new/@heroui/dropdown@5209

@heroui/form

npm i https://pkg.pr.new/@heroui/form@5209

@heroui/image

npm i https://pkg.pr.new/@heroui/image@5209

@heroui/input

npm i https://pkg.pr.new/@heroui/input@5209

@heroui/input-otp

npm i https://pkg.pr.new/@heroui/input-otp@5209

@heroui/kbd

npm i https://pkg.pr.new/@heroui/kbd@5209

@heroui/link

npm i https://pkg.pr.new/@heroui/link@5209

@heroui/listbox

npm i https://pkg.pr.new/@heroui/listbox@5209

@heroui/menu

npm i https://pkg.pr.new/@heroui/menu@5209

@heroui/modal

npm i https://pkg.pr.new/@heroui/modal@5209

@heroui/navbar

npm i https://pkg.pr.new/@heroui/navbar@5209

@heroui/number-input

npm i https://pkg.pr.new/@heroui/number-input@5209

@heroui/pagination

npm i https://pkg.pr.new/@heroui/pagination@5209

@heroui/popover

npm i https://pkg.pr.new/@heroui/popover@5209

@heroui/progress

npm i https://pkg.pr.new/@heroui/progress@5209

@heroui/radio

npm i https://pkg.pr.new/@heroui/radio@5209

@heroui/ripple

npm i https://pkg.pr.new/@heroui/ripple@5209

@heroui/scroll-shadow

npm i https://pkg.pr.new/@heroui/scroll-shadow@5209

@heroui/select

npm i https://pkg.pr.new/@heroui/select@5209

@heroui/skeleton

npm i https://pkg.pr.new/@heroui/skeleton@5209

@heroui/slider

npm i https://pkg.pr.new/@heroui/slider@5209

@heroui/snippet

npm i https://pkg.pr.new/@heroui/snippet@5209

@heroui/spacer

npm i https://pkg.pr.new/@heroui/spacer@5209

@heroui/spinner

npm i https://pkg.pr.new/@heroui/spinner@5209

@heroui/switch

npm i https://pkg.pr.new/@heroui/switch@5209

@heroui/table

npm i https://pkg.pr.new/@heroui/table@5209

@heroui/tabs

npm i https://pkg.pr.new/@heroui/tabs@5209

@heroui/toast

npm i https://pkg.pr.new/@heroui/toast@5209

@heroui/tooltip

npm i https://pkg.pr.new/@heroui/tooltip@5209

@heroui/user

npm i https://pkg.pr.new/@heroui/user@5209

@heroui/react

npm i https://pkg.pr.new/@heroui/react@5209

@heroui/system

npm i https://pkg.pr.new/@heroui/system@5209

@heroui/system-rsc

npm i https://pkg.pr.new/@heroui/system-rsc@5209

@heroui/theme

npm i https://pkg.pr.new/@heroui/theme@5209

@heroui/use-aria-accordion

npm i https://pkg.pr.new/@heroui/use-aria-accordion@5209

@heroui/use-aria-accordion-item

npm i https://pkg.pr.new/@heroui/use-aria-accordion-item@5209

@heroui/use-aria-button

npm i https://pkg.pr.new/@heroui/use-aria-button@5209

@heroui/use-aria-link

npm i https://pkg.pr.new/@heroui/use-aria-link@5209

@heroui/use-aria-modal-overlay

npm i https://pkg.pr.new/@heroui/use-aria-modal-overlay@5209

@heroui/use-aria-multiselect

npm i https://pkg.pr.new/@heroui/use-aria-multiselect@5209

@heroui/use-callback-ref

npm i https://pkg.pr.new/@heroui/use-callback-ref@5209

@heroui/use-clipboard

npm i https://pkg.pr.new/@heroui/use-clipboard@5209

@heroui/use-data-scroll-overflow

npm i https://pkg.pr.new/@heroui/use-data-scroll-overflow@5209

@heroui/use-disclosure

npm i https://pkg.pr.new/@heroui/use-disclosure@5209

@heroui/use-draggable

npm i https://pkg.pr.new/@heroui/use-draggable@5209

@heroui/use-image

npm i https://pkg.pr.new/@heroui/use-image@5209

@heroui/use-infinite-scroll

npm i https://pkg.pr.new/@heroui/use-infinite-scroll@5209

@heroui/use-intersection-observer

npm i https://pkg.pr.new/@heroui/use-intersection-observer@5209

@heroui/use-is-mobile

npm i https://pkg.pr.new/@heroui/use-is-mobile@5209

@heroui/use-is-mounted

npm i https://pkg.pr.new/@heroui/use-is-mounted@5209

@heroui/use-measure

npm i https://pkg.pr.new/@heroui/use-measure@5209

@heroui/use-pagination

npm i https://pkg.pr.new/@heroui/use-pagination@5209

@heroui/use-ref-state

npm i https://pkg.pr.new/@heroui/use-ref-state@5209

@heroui/use-real-shape

npm i https://pkg.pr.new/@heroui/use-real-shape@5209

@heroui/use-resize

npm i https://pkg.pr.new/@heroui/use-resize@5209

@heroui/use-scroll-position

npm i https://pkg.pr.new/@heroui/use-scroll-position@5209

@heroui/use-safe-layout-effect

npm i https://pkg.pr.new/@heroui/use-safe-layout-effect@5209

@heroui/use-ssr

npm i https://pkg.pr.new/@heroui/use-ssr@5209

@heroui/use-theme

npm i https://pkg.pr.new/@heroui/use-theme@5209

@heroui/use-update-effect

npm i https://pkg.pr.new/@heroui/use-update-effect@5209

@heroui/aria-utils

npm i https://pkg.pr.new/@heroui/aria-utils@5209

@heroui/dom-animation

npm i https://pkg.pr.new/@heroui/dom-animation@5209

@heroui/framer-utils

npm i https://pkg.pr.new/@heroui/framer-utils@5209

@heroui/react-rsc-utils

npm i https://pkg.pr.new/@heroui/react-rsc-utils@5209

@heroui/react-utils

npm i https://pkg.pr.new/@heroui/react-utils@5209

@heroui/shared-icons

npm i https://pkg.pr.new/@heroui/shared-icons@5209

@heroui/shared-utils

npm i https://pkg.pr.new/@heroui/shared-utils@5209

@heroui/stories-utils

npm i https://pkg.pr.new/@heroui/stories-utils@5209

@heroui/test-utils

npm i https://pkg.pr.new/@heroui/test-utils@5209

commit: ff17098