fix(table): sticky header & content placement in virtualized table#5184
Merged
Conversation
…m content placement fix
🦋 Changeset detectedLatest commit: ed4a5fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Hova25 is attempting to deploy a commit to the HeroUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
""" WalkthroughThe pull request adds a new changelog entry for the “@heroui/table” package and implements several adjustments in the virtualized table component. The changes include restructuring property handling, conditional content rendering modifications, and simplified prop passing. A new story export is introduced to enable a sticky header configuration, and a theme update adjusts the table’s body styling. These modifications collectively address the header stickiness issue reported in the linked bug. Changes
Sequence Diagram(s)sequenceDiagram
participant S as Storybook
participant VT as VirtualizedTable
participant CP as TableProp Generator
participant RV as RowVirtualizer
S->>VT: Render VirtualizedWithHeaderSticky
VT->>CP: getTableProps()
CP-->>VT: Return tableProps
VT->>RV: getTotalSize()
RV-->>VT: Return totalSize
VT->>VT: Calculate dynamic height style using totalSize & headerHeight
alt Check topContentPlacement
VT->>S: Render topContent (outside Wrapper)
else Alternative placement
VT->>VT: Render topContent inside main structure
end
VT->>S: Render table header with sticky behavior if isHeaderSticky is true
VT->>S: Render table rows via VirtualizedTableBody
Assessment against linked issues
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@heroui/accordion
@heroui/autocomplete
@heroui/alert
@heroui/avatar
@heroui/badge
@heroui/breadcrumbs
@heroui/button
@heroui/calendar
@heroui/card
@heroui/checkbox
@heroui/chip
@heroui/code
@heroui/date-input
@heroui/date-picker
@heroui/divider
@heroui/drawer
@heroui/dropdown
@heroui/form
@heroui/image
@heroui/input
@heroui/input-otp
@heroui/kbd
@heroui/link
@heroui/listbox
@heroui/menu
@heroui/modal
@heroui/navbar
@heroui/number-input
@heroui/pagination
@heroui/popover
@heroui/progress
@heroui/radio
@heroui/ripple
@heroui/scroll-shadow
@heroui/select
@heroui/skeleton
@heroui/slider
@heroui/snippet
@heroui/spacer
@heroui/switch
@heroui/spinner
@heroui/table
@heroui/tabs
@heroui/toast
@heroui/tooltip
@heroui/user
@heroui/react
@heroui/system
@heroui/system-rsc
@heroui/theme
@heroui/use-aria-accordion
@heroui/use-aria-accordion-item
@heroui/use-aria-button
@heroui/use-aria-link
@heroui/use-aria-modal-overlay
@heroui/use-aria-multiselect
@heroui/use-callback-ref
@heroui/use-clipboard
@heroui/use-data-scroll-overflow
@heroui/use-disclosure
@heroui/use-draggable
@heroui/use-image
@heroui/use-infinite-scroll
@heroui/use-intersection-observer
@heroui/use-is-mobile
@heroui/use-is-mounted
@heroui/use-measure
@heroui/use-pagination
@heroui/use-real-shape
@heroui/use-ref-state
@heroui/use-resize
@heroui/use-safe-layout-effect
@heroui/use-scroll-position
@heroui/use-ssr
@heroui/use-theme
@heroui/use-update-effect
@heroui/aria-utils
@heroui/dom-animation
@heroui/framer-utils
@heroui/react-rsc-utils
@heroui/react-utils
@heroui/shared-icons
@heroui/shared-utils
@heroui/stories-utils
@heroui/test-utils
commit: |
wingkwong
requested changes
Apr 11, 2025
Member
wingkwong
left a comment
wingkwong
left a comment
There was a problem hiding this comment.
please edit PR description to explain the changes.
Contributor
Author
|
Thanks for the PR review @wingkwong, I've applied the suggested changes. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wingkwong
approved these changes
Apr 18, 2025
wingkwong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5149
📝 Description
Fix header sticky in virtualized table
I have fixed also topContent outside placement and bottomContent outside placement in virtualized table
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No)
No
Summary by CodeRabbit
New Features
Bug Fixes
Style