Skip to content

fix(theme): hover-opacity in Link & Breadcrumb#5170

Merged
jrgarciadev merged 5 commits into
heroui-inc:canaryfrom
Nathanael-Shermett:patch-1
Apr 19, 2025
Merged

fix(theme): hover-opacity in Link & Breadcrumb#5170
jrgarciadev merged 5 commits into
heroui-inc:canaryfrom
Nathanael-Shermett:patch-1

Conversation

@Nathanael-Shermett
Copy link
Copy Markdown

@Nathanael-Shermett Nathanael-Shermett commented Apr 9, 2025 •
edited by coderabbitai Bot
Loading

Closes #5169

📝 Description

The hover behavior of HeroUI <Link> components is inconsistent with theme configuration.

⛳️ Current behavior (updates)

<Link> component currently has a hardcoded hover opacity of 80% for non-block links.

🚀 New behavior

<Link> component utilizes layout hoverOpacity variable (i.e., hover:opacity-hover).

💣 Is this a breaking change (Yes/No):

No.

📝 Additional Information

N/A

Summary by CodeRabbit

  • Style
    • Updated hover opacity for link and breadcrumb components to use a semantic variable, enhancing visual feedback on interaction.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: eb3d08f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@heroui/theme Patch
@heroui/autocomplete Patch
@heroui/checkbox Patch
@heroui/date-input Patch
@heroui/date-picker Patch
@heroui/form Patch
@heroui/input-otp Patch
@heroui/input Patch
@heroui/number-input Patch
@heroui/radio Patch
@heroui/select Patch
@heroui/table Patch
@heroui/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 9, 2025

@Nathanael-Shermett is attempting to deploy a commit to the HeroUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

@Nathanael-Shermett Nathanael-Shermett changed the title Utilize hover-opacity in <Link> component. Utilize hover-opacity in <Link> component Apr 9, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 9, 2025 •
edited
Loading

Walkthrough

The pull request updates the link and breadcrumbs components in the core theme package by modifying their CSS classes for hover opacity. The fixed opacity value "hover:opacity-80" is replaced with "hover:opacity-hover" in both components, allowing the hover opacity to be driven by the theme’s layout.hoverOpacity token. Additionally, a new entry is added to the changeset file indicating a patch for the @heroui/theme package related to this change. No changes were made to the public API.

Changes

Files Change Summary
packages/core/theme/src/components/link.ts and packages/core/theme/src/components/breadcrumbs.ts Replaced fixed hover opacity class "hover:opacity-80" with theme-driven "hover:opacity-hover" in link and breadcrumb components.
.changeset/quick-coats-raise.md Added a new entry indicating a patch for the @heroui/theme package related to hover opacity in the <Link> and Breadcrumb components.

Assessment against linked issues

Objective Addressed Explanation
component reflects theme-defined hover opacity [#5169] ✅

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8dc3c9 and eb3d08f.

📒 Files selected for processing (2)
  • .changeset/quick-coats-raise.md (1 hunks)
  • packages/core/theme/src/components/breadcrumbs.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/quick-coats-raise.md
🔇 Additional comments (1)
packages/core/theme/src/components/breadcrumbs.ts (1)

87-87: Great improvement to use the theme token for hover opacity!

This change replaces the hardcoded "hover:opacity-80" with "hover:opacity-hover", which aligns the breadcrumbs component with the theme's configured hover opacity. This ensures consistent hover behavior across components and improves theme customization capabilities.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Nathanael-Shermett Nathanael-Shermett mentioned this pull request Apr 9, 2025
Closed
wingkwong
wingkwong requested changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include a changeset file.

@Nathanael-Shermett Nathanael-Shermett changed the title Utilize hover-opacity in <Link> component fix(link): hover-opacity in <Link> component Apr 9, 2025
coderabbitai[bot]
coderabbitai Bot reviewed Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changeset/quick-coats-raise.md (1)

5-5: Improve Description Clarity.
Consider rephrasing the description to "Utilize hover-opacity in the <Link> component." This minor adjustment (adding "the") improves readability and clarity.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~5-~5: You might be missing the article “the” here.
Context: ...: patch --- Utilize hover-opacity in component.

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d8449f and ebf6710.

📒 Files selected for processing (1)
  • .changeset/quick-coats-raise.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
.changeset/quick-coats-raise.md

[uncategorized] ~5-~5: You might be missing the article “the” here.
Context: ...: patch --- Utilize hover-opacity in component.

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

🔇 Additional comments (1)
.changeset/quick-coats-raise.md (1)

1-3: Changeset Header is Correctly Defined.
The patch entry for "@heroui/theme": patch is correctly indicated in the header. This clearly conveys that the update is a patch release for the theme package.

@wingkwong wingkwong added this to the v2.7.7 milestone Apr 9, 2025
@wingkwong wingkwong self-requested a review April 9, 2025 17:03
@wingkwong wingkwong self-assigned this Apr 9, 2025
@wingkwong wingkwong changed the base branch from main to canary April 18, 2025 03:16
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
heroui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 3:40am
heroui-sb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 3:40am

@wingkwong wingkwong changed the title fix(link): hover-opacity in <Link> component fix(theme): hover-opacity in Link & Breadcrumb Apr 18, 2025
@wingkwong wingkwong assigned jrgarciadev and unassigned wingkwong Apr 18, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 18, 2025

Open in StackBlitz

@heroui/accordion

npm i https://pkg.pr.new/@heroui/accordion@5170

@heroui/autocomplete

npm i https://pkg.pr.new/@heroui/autocomplete@5170

@heroui/alert

npm i https://pkg.pr.new/@heroui/alert@5170

@heroui/avatar

npm i https://pkg.pr.new/@heroui/avatar@5170

@heroui/badge

npm i https://pkg.pr.new/@heroui/badge@5170

@heroui/breadcrumbs

npm i https://pkg.pr.new/@heroui/breadcrumbs@5170

@heroui/button

npm i https://pkg.pr.new/@heroui/button@5170

@heroui/calendar

npm i https://pkg.pr.new/@heroui/calendar@5170

@heroui/card

npm i https://pkg.pr.new/@heroui/card@5170

@heroui/checkbox

npm i https://pkg.pr.new/@heroui/checkbox@5170

@heroui/chip

npm i https://pkg.pr.new/@heroui/chip@5170

@heroui/code

npm i https://pkg.pr.new/@heroui/code@5170

@heroui/date-input

npm i https://pkg.pr.new/@heroui/date-input@5170

@heroui/date-picker

npm i https://pkg.pr.new/@heroui/date-picker@5170

@heroui/divider

npm i https://pkg.pr.new/@heroui/divider@5170

@heroui/drawer

npm i https://pkg.pr.new/@heroui/drawer@5170

@heroui/dropdown

npm i https://pkg.pr.new/@heroui/dropdown@5170

@heroui/form

npm i https://pkg.pr.new/@heroui/form@5170

@heroui/image

npm i https://pkg.pr.new/@heroui/image@5170

@heroui/input

npm i https://pkg.pr.new/@heroui/input@5170

@heroui/input-otp

npm i https://pkg.pr.new/@heroui/input-otp@5170

@heroui/kbd

npm i https://pkg.pr.new/@heroui/kbd@5170

@heroui/link

npm i https://pkg.pr.new/@heroui/link@5170

@heroui/listbox

npm i https://pkg.pr.new/@heroui/listbox@5170

@heroui/menu

npm i https://pkg.pr.new/@heroui/menu@5170

@heroui/modal

npm i https://pkg.pr.new/@heroui/modal@5170

@heroui/navbar

npm i https://pkg.pr.new/@heroui/navbar@5170

@heroui/number-input

npm i https://pkg.pr.new/@heroui/number-input@5170

@heroui/pagination

npm i https://pkg.pr.new/@heroui/pagination@5170

@heroui/popover

npm i https://pkg.pr.new/@heroui/popover@5170

@heroui/progress

npm i https://pkg.pr.new/@heroui/progress@5170

@heroui/radio

npm i https://pkg.pr.new/@heroui/radio@5170

@heroui/ripple

npm i https://pkg.pr.new/@heroui/ripple@5170

@heroui/scroll-shadow

npm i https://pkg.pr.new/@heroui/scroll-shadow@5170

@heroui/select

npm i https://pkg.pr.new/@heroui/select@5170

@heroui/skeleton

npm i https://pkg.pr.new/@heroui/skeleton@5170

@heroui/slider

npm i https://pkg.pr.new/@heroui/slider@5170

@heroui/snippet

npm i https://pkg.pr.new/@heroui/snippet@5170

@heroui/spacer

npm i https://pkg.pr.new/@heroui/spacer@5170

@heroui/spinner

npm i https://pkg.pr.new/@heroui/spinner@5170

@heroui/switch

npm i https://pkg.pr.new/@heroui/switch@5170

@heroui/table

npm i https://pkg.pr.new/@heroui/table@5170

@heroui/tabs

npm i https://pkg.pr.new/@heroui/tabs@5170

@heroui/toast

npm i https://pkg.pr.new/@heroui/toast@5170

@heroui/tooltip

npm i https://pkg.pr.new/@heroui/tooltip@5170

@heroui/user

npm i https://pkg.pr.new/@heroui/user@5170

@heroui/react

npm i https://pkg.pr.new/@heroui/react@5170

@heroui/system

npm i https://pkg.pr.new/@heroui/system@5170

@heroui/system-rsc

npm i https://pkg.pr.new/@heroui/system-rsc@5170

@heroui/theme

npm i https://pkg.pr.new/@heroui/theme@5170

@heroui/use-aria-accordion

npm i https://pkg.pr.new/@heroui/use-aria-accordion@5170

@heroui/use-aria-accordion-item

npm i https://pkg.pr.new/@heroui/use-aria-accordion-item@5170

@heroui/use-aria-button

npm i https://pkg.pr.new/@heroui/use-aria-button@5170

@heroui/use-aria-link

npm i https://pkg.pr.new/@heroui/use-aria-link@5170

@heroui/use-aria-modal-overlay

npm i https://pkg.pr.new/@heroui/use-aria-modal-overlay@5170

@heroui/use-aria-multiselect

npm i https://pkg.pr.new/@heroui/use-aria-multiselect@5170

@heroui/use-callback-ref

npm i https://pkg.pr.new/@heroui/use-callback-ref@5170

@heroui/use-clipboard

npm i https://pkg.pr.new/@heroui/use-clipboard@5170

@heroui/use-data-scroll-overflow

npm i https://pkg.pr.new/@heroui/use-data-scroll-overflow@5170

@heroui/use-disclosure

npm i https://pkg.pr.new/@heroui/use-disclosure@5170

@heroui/use-draggable

npm i https://pkg.pr.new/@heroui/use-draggable@5170

@heroui/use-image

npm i https://pkg.pr.new/@heroui/use-image@5170

@heroui/use-infinite-scroll

npm i https://pkg.pr.new/@heroui/use-infinite-scroll@5170

@heroui/use-intersection-observer

npm i https://pkg.pr.new/@heroui/use-intersection-observer@5170

@heroui/use-is-mobile

npm i https://pkg.pr.new/@heroui/use-is-mobile@5170

@heroui/use-is-mounted

npm i https://pkg.pr.new/@heroui/use-is-mounted@5170

@heroui/use-measure

npm i https://pkg.pr.new/@heroui/use-measure@5170

@heroui/use-pagination

npm i https://pkg.pr.new/@heroui/use-pagination@5170

@heroui/use-real-shape

npm i https://pkg.pr.new/@heroui/use-real-shape@5170

@heroui/use-ref-state

npm i https://pkg.pr.new/@heroui/use-ref-state@5170

@heroui/use-resize

npm i https://pkg.pr.new/@heroui/use-resize@5170

@heroui/use-safe-layout-effect

npm i https://pkg.pr.new/@heroui/use-safe-layout-effect@5170

@heroui/use-scroll-position

npm i https://pkg.pr.new/@heroui/use-scroll-position@5170

@heroui/use-ssr

npm i https://pkg.pr.new/@heroui/use-ssr@5170

@heroui/use-theme

npm i https://pkg.pr.new/@heroui/use-theme@5170

@heroui/use-update-effect

npm i https://pkg.pr.new/@heroui/use-update-effect@5170

@heroui/aria-utils

npm i https://pkg.pr.new/@heroui/aria-utils@5170

@heroui/dom-animation

npm i https://pkg.pr.new/@heroui/dom-animation@5170

@heroui/framer-utils

npm i https://pkg.pr.new/@heroui/framer-utils@5170

@heroui/react-rsc-utils

npm i https://pkg.pr.new/@heroui/react-rsc-utils@5170

@heroui/shared-icons

npm i https://pkg.pr.new/@heroui/shared-icons@5170

@heroui/react-utils

npm i https://pkg.pr.new/@heroui/react-utils@5170

@heroui/shared-utils

npm i https://pkg.pr.new/@heroui/shared-utils@5170

@heroui/stories-utils

npm i https://pkg.pr.new/@heroui/stories-utils@5170

@heroui/test-utils

npm i https://pkg.pr.new/@heroui/test-utils@5170

commit: eb3d08f

AnYiEE added a commit to AnYiEE/touhou-mystia-izakaya-assistant that referenced this pull request Apr 18, 2025
@AnYiEE
fix(design/ui/components/link): use hover-opacity
8d33363 
see: heroui-inc/heroui#5170
@jrgarciadev jrgarciadev merged commit f223e1f into heroui-inc:canary Apr 19, 2025
10 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 19, 2025
Merged
@github-actions github-actions Bot mentioned this pull request Apr 28, 2025
Merged
AnYiEE added a commit to AnYiEE/touhou-mystia-izakaya-assistant that referenced this pull request Jun 2, 2025
@AnYiEE
fix(components): apply HeroUI patches
9183edc 
heroui-inc/heroui#3917
heroui-inc/heroui#5170
heroui-inc/heroui#5252
heroui-inc/heroui#5286
heroui-inc/heroui#5290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wingkwong wingkwong wingkwong approved these changes

@jrgarciadev jrgarciadev Awaiting requested review from jrgarciadev

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jrgarciadev jrgarciadev

Labels

None yet

Projects

None yet

Milestone

v2.7.8

Development

Successfully merging this pull request may close these issues.

[BUG] - <Link> component unaffected by hoverOpacity

3 participants

@Nathanael-Shermett @wingkwong @jrgarciadev