Skip to content

Fix ios open in chat#5040

Merged
jrgarciadev merged 109 commits into
mainfrom
canary
Mar 12, 2025
Merged

Fix ios open in chat#5040
jrgarciadev merged 109 commits into
mainfrom
canary

Conversation

@jrgarciadev
Copy link
Copy Markdown
Member

@jrgarciadev jrgarciadev commented Mar 12, 2025

Closes #

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • New Features
    • Improved the user experience by reusing a single browser tab for chat-related content. The updated behavior now opens one tab and directs it to the relevant URL, reducing unnecessary multiple tabs.
    • Enhanced error handling ensures that if the chat content fails to load, the opened tab is automatically closed, promoting a cleaner browsing experience.

wingkwong and others added 30 commits January 19, 2025 09:33
* chore(deps): bump RA versions

* chore(deps): bump @internationalized/date

* chore(docs): update RA versions

* chore(docs): update versions

* chore(docs): use string type

* chore(deps): update @react-types versions

* refactor(docs): undo version change since they will be removed in another PR
* feat: tailwind variants upgrade

* chore: restore npmrc

* chore: adjust pkgs

* fix: versions

* fix: lock file

* chore(changeset): update package name

* chore(deps): use fixed version

* fix(test): incorrect package name

---------

Co-authored-by: աӄա <wingkwong.code@gmail.com>
* feat: add new keys

* feat: add new keys

* chore: update docs & storybook as well

---------

Co-authored-by: WK Wong <wingkwong.code@gmail.com>
* fix(use-image): load image after props change

* chore(changeset): add changeset

* refactor(use-image): remove unused props

* feat(use-image): add test case

* fix(use-image): apply useCallback to load & remove status check

* chore(changeset): update package name
* feat: adding the support for labelPlacement globally

* chore: reafctoring

* chore: updating the dependency

* chore(changeset): update package name

* chore: adding Marcus's suggestions

---------

Co-authored-by: աӄա <wingkwong.code@gmail.com>
* fix(form): use native as default validation behavior

* docs(form): delete explicit validationBehavior=native

* test(form): adjusted form test validation behaviors

* chore(form): adjusted stories with forms

* chore(changeset): changed form default validation behavior to native

* chore(changeset): removed packages with only test changes

* chore(changeset): change to patch

* chore(changeset): update package name

* refactor(docs): update package name

* refactor(docs): update to heroui

---------

Co-authored-by: աӄա <wingkwong.code@gmail.com>
* refactor(spinner): add default variant

* feature(spinner): add gradient variant

* feature(spinner): add dots variant

* feature(spinner): add dots-blink variant

* feature(spinner): add spinner-bars

* chore(spinner): add variants storybook

* chore: adding variants to docs

* chore: simplyfying the styles and modifying docs

* chore: nits

* chore: updating the dots and dots-blink animation

* chore: nits

* chore: adding Marcus' suggestions

* chore: adding Marcus's suggestions

* chore: adding junior's suggestions

---------

Co-authored-by: Maharshi Alpesh <maharshialpesh@gmail.com>
* fix: rename wrapper to tab wrapper

* docs: update

* docs: update

* docs: update

* fix: rename wrapper to tab wrapper
* refactor(.github): remove feature request template

* refactor(.github): add a link to redirect to discussion (feature request category)
* fix(listbox): add scroll height & scroll top to listbox

* fix(use-data-scroll-overflow): handle scrollHeight & scrollTop in virtualization

* chore(changeset): add changeset
* chore(date-picker): add missing slots comments

* fix(date-picker): remove dateInputClassNames

* fix(date-picker): use classNames instead of dateInputClassNames

* chore(docs): add missing attributes

* fix(date-picker): use classNames instead of dateInputClassNames

* feat(changeset): add changeset

* fix(docs): broken type
* refactor: remove dropdown menu width

* refactor: shorter description
* docs: use the correct org for `img.shields.io` license in README

* docs: update opencollective org name

* docs: use correct org name in site footer

* docs: update image urls for heroui pro sections

* docs: update laravel installation keywords in route config

* docs: add `heroui` tag to `Introducing HeroUI` blog post

* fix: use correct names in `plop/components/src` templates

* chore: add empty changeset

* fix: revert image urls back to `nextuipro.nyc3.cdn.digitaloceanspaces...`

* chore: undo footer change

* chore: update incorrect brand name

* chore(docs): nextui -> heroui

---------

Co-authored-by: աӄա <wingkwong.code@gmail.com>
* fix(theme): sync with input theme on labelPlacement

* chore(select): revise width for labelPlacement

* chore(changeset): add changeset
* test(input): user interaction tests

* test(input): missing act wrappers

---------

Co-authored-by: WK Wong <wingkwong.code@gmail.com>
* fix(calendar): rtl navigation

* chore(changeset): fixed reverse behavior of NextButton and PrevButton in the RTL calendar

* chore(changeset): update package name

* refactor(calendar): prefer isRTL and use className in theme package instead

* chore(changeset): add theme package as well

* chore(calendar): add min theme package to 2.4.7

---------

Co-authored-by: աӄա <wingkwong.code@gmail.com>
…consistent (#4558)

* refactor: remove unnecessary className passing to tv

* refactor(button): move styles to getButtonProps

* refactor: rename classNames to styles to keep the naming consistent
* fix(use-aria-link): onClick deprecation warning

* fix(use-aria-button): onClick deprecation warning

* feat(changeset): add changeset

* fix(use-aria-button): incorrect prop name

* chore(changeset): update package name
* ci: add pkg pr new

* ci: add pkg pr new

* chore(workflow): update repo name

---------

Co-authored-by: աӄա <wingkwong.code@gmail.com>
* fix(use-pagination): add page to dependency for scrollTo

* feat(changeset): add changeset

* chore(changeset): update package name
)

* fix(tooltip): accessing element.ref was removed in React 19 issue

* chore(changeset): update package name
github-actions Bot and others added 23 commits February 28, 2025 01:45
Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>
* chore(deps): bump turbo version

* chore(root): update turbo.json

* fix(docs): typecheck errors

* fix(docs): typecheck errors
* fix(deps): bump react-aria versions

* chore(changeset): add changeset

* chore(hooks): sync with RA's useButton

* fix(use-aria-button): support aria-current

* fix(docs): remove priority prop

* fix(toast): remove priority queue & animation

* fix(toast): remove deprecated logic

* fix(popover): avoid passing preventFocusOnPress to non heroui button

* fix: sync with UsePopover

* fix(popover): prevent submenus from closing on scroll

* fix(tests): test cases related to press refactoring
…to ToastProvider (#5001)

* fix: toast should be above the modal

* fix: renaming the loadingIcon to loadingComponent

* chore: adding changeset

* chore: fixing conflicts

* chore: adding the region props

* fix: adding Marcus' suggestions

* fix: marcus' suggestions

* Revert "fix: renaming the loadingIcon to loadingComponent"

This reverts commit 4c6bf32.

* chore: adding marcus' suggestions
* fix(progress): add RTL support to the progress component (#4908)

* docs(progress): add changeset notes

* refactor: resolved code review notes

* refactor: removed unnecessary change

* refactor: undo unnecessary change
* fix(deps): use RA beta toast

* chore(toast): remove non-existing wrapUpdate

* chore(changeset): add changeset
Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>
* feat: open in chat button in doc examples

* feat: pass dependencies in open in chat

* fix: open in chat error handling

* chore: small adjustment

---------

Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>
* fix: open in chat ignore react imports

* fix: open in chat utm params

* fix: open in chat utm source
* fix(docs): parse dependency match imported components against heroui

* fix(docs): center open in chat components
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 12, 2025

⚠️ No Changeset found

Latest commit: 1fc68fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
heroui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 9:34pm
heroui-sb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 9:34pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This change refactors the Code Demo component by introducing a single reusable browser tab for the chat functionality. A new variable, newTab, is created using window.open(undefined, "_blank") to open a tab once. The component then updates this tab's location with a URL returned from the openInChat function or closes it if an error occurs or no data is returned. This approach prevents multiple tabs from opening during repeated executions of the handleOpenInChat function.

Changes

File(s) Change Summary
apps/.../code-demo.tsx Introduced a newTab variable to open a single tab via window.open(undefined, "_blank"). Updated the handleOpenInChat function to set newTab.location.href with returned data or close the tab with newTab.close() when an error occurs or no data is returned.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant C as CodeDemo Component
    participant W as Window
    participant O as openInChat Function

    U->>C: trigger handleOpenInChat
    C->>W: window.open(undefined, "_blank") -> newTab
    C->>O: call openInChat()
    O-->>C: return data / error
    alt Valid URL received
        C->>W: set newTab.location.href = data
    else Error or no data
        C->>W: newTab.close()
    end
Loading

Possibly related PRs

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

 ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS  Optional dependencies cannot be installed without production dependencies

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b3a7d3 and 1fc68fb.

📒 Files selected for processing (1)
  • apps/docs/components/docs/components/code-demo/code-demo.tsx (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.