Skip to content

feat: support tailwindcss v4#4656

Merged
jrgarciadev merged 36 commits into
beta/release-nextfrom
feat/tailwindcss-v4
Mar 8, 2025
Merged

feat: support tailwindcss v4#4656
jrgarciadev merged 36 commits into
beta/release-nextfrom
feat/tailwindcss-v4

Conversation

@winchesHe
Copy link
Copy Markdown
Contributor

@winchesHe winchesHe commented Jan 26, 2025

Closes #4644

Description

The current migration is working fine with tailwindcss js config.

It won't be released that soon because it has a lot of breaking changes.

Need to update

  1. tailwind-merge upgrade ✅
  2. codemod support heroui plugin transform to css file

Migration steps

  1. Follow the official upgrade guide https://tailwindcss.com/docs/upgrade-guide
  2. Install the preview version feat: support tailwindcss v4 #4656 (comment)
  3. Use heroui with @config "path/to/tailwindcss"

Heroui template for tailwindcss v4

heroui-inc/vite-template#10

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: 06a9761

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
heroui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2025 7:33pm
heroui-sb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2025 7:33pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (5)
  • main
  • canary
  • fix/.*
  • chore/.*
  • feat/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wingkwong wingkwong changed the title Feat/tailwindcss v4 feat: support tailwindcss v4 Jan 28, 2025
@winchesHe
Copy link
Copy Markdown
Contributor Author

winchesHe commented Feb 19, 2025

tailwindlabs/tailwindcss#16664 related to ease-out important modifier issue

@christophmeise
Copy link
Copy Markdown

When I use any of these preview versions I get an runtime error:

Parsing css source code failed
  2979 |   }
  2980 |   .w-\[calc\(100\%_-_var\(spacing\.6\)\)\] {
> 2981 |     width: calc(100% - var(spacing.6));
       |                             ^
  2982 |   }
  2983 |   .w-\[calc\(2623\/16\*1rem\)\] {
  2984 |     width: calc(2623 / 16 * 1rem);

Unexpected token Ident("spacing") at [project]/apps/nextjs/src/styles/globals.css:2980:28

I can confirm that this error goes away as soon as I remove the heroui content import from the tailwind config: ../../node_modules/@heroui/theme/dist/**/*.{js,ts,jsx,tsx}
I also removed all CSS and plugins to confirm that this is a problem with heroui.

Using Tailwind 4.0.9, Nextjs 15.0.2 and tried both of the latest beta preview versions. I checked the implementation of the vite example and I am doing it exactly like that.

@winchesHe
Copy link
Copy Markdown
Contributor Author

When I use any of these preview versions I get an runtime error:

Parsing css source code failed
  2979 |   }
  2980 |   .w-\[calc\(100\%_-_var\(spacing\.6\)\)\] {
> 2981 |     width: calc(100% - var(spacing.6));
       |                             ^
  2982 |   }
  2983 |   .w-\[calc\(2623\/16\*1rem\)\] {
  2984 |     width: calc(2623 / 16 * 1rem);

Unexpected token Ident("spacing") at [project]/apps/nextjs/src/styles/globals.css:2980:28

I can confirm that this error goes away as soon as I remove the heroui content import from the tailwind config: ../../node_modules/@heroui/theme/dist/**/*.{js,ts,jsx,tsx} I also removed all CSS and plugins to confirm that this is a problem with heroui.

Using Tailwind 4.0.9, Nextjs 15.0.2 and tried both of the latest beta preview versions. I checked the implementation of the vite example and I am doing it exactly like that.

Fixed in the latest version https://github.com/heroui-inc/heroui/runs/37994128721

@aeltorio
Copy link
Copy Markdown

aeltorio commented Mar 2, 2025

@winchesHe ,
Thank you for your impressive work.
I've updated the template React 19, TailwindCSS 4.0.9, ESLint 9, Heroui 2.7… with
https://github.com/sctg-development/vite-react-heroui-template
Thanks a lot

@Ankan002
Copy link
Copy Markdown

Ankan002 commented Mar 8, 2025

Does this also support nextjs?

@aeltorio
Copy link
Copy Markdown

aeltorio commented Mar 18, 2025

I have synced my template to beta build.
For our needs, I have added i18n support and a simple language-switching component to change the language. This component correctly handles both LTR and RTL languages. Please note that the languages are automatically translated.

image image

The template without i18n ends at e8d9065d36ef09c90714b099406ee6a737ef32c3

@sapjax
Copy link
Copy Markdown

sapjax commented Apr 25, 2025

I found that heroui doesn't support using-a-data-attribute as dark mode selector

@custom-variant dark (&:where([data-theme=dark], [data-theme=dark] *));

It only works with class selector:

@custom-variant dark (&:where(.dark, .dark *));

wingkwong added a commit that referenced this pull request May 2, 2025
* chore(pre-release): enter pre-release mode

* feat: support tailwindcss v4 (#4656)

* feat: upgrade tailwindcssv4

* feat: upgrade tailwindcssv4

* feat: update config

* feat: first init tailwindcss v4

* fix: update shadow xs to sm

* fix: update rounded xs to sm

* fix: variant issues

* fix: variant shadow etc issues

* fix: variant shadow issues

* fix: redundant shadow issues

* fix: redundant blur-sm issues

* fix: redundant blur-sm issues

* fix: redundant blur-sm shadow issues

* fix: remove redundant rename

* fix: role button issues

* fix: role button issues

* fix: font size

* fix: alpha color value

* fix: support text utilities in plugin

* feat: upgrade tailwind-merge

* fix: pkg package scope

(cherry picked from commit 6e82323)

* fix: button base ui add cursor pointer

* fix: tailwindcss experimental

* feat: upgrade tailwindcss version

* fix: input step 1

* fix: input transition issue

* fix: theme to var function

* ci: run QA in beta branch

* fix: var to the theme and incorrect var usage MER-3261

* feat: upgrade tailwind-variants

---------

Co-authored-by: WK Wong <wingkwong.code@gmail.com>
Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>

* feat: changeset for tailwindcss v4

* fix: changeset

* fix: changeset

* ci(changesets): version packages (beta) (#5008)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: tw 4 docs

* fix: select tests

* chore: timeout

* ci(changesets): version packages (beta)

* ci(changesets): version packages (beta)

* fix: deployment

* ci(changesets): version packages (beta) (#5009)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: add the cli to upgrade the packages to beta

* fix: cli command

* fix: revert to use previous version (#5012)

* fix: revert to use previous version

* fix: revert to use previous version

* fix: revert

* fix: revert to use previous tailwind-merge version

* ci(changesets): version packages (beta) (#5015)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: adapt tailwind merger config (#5016)

* Revert "fix: revert to use previous version (#5012)"

This reverts commit 1d01df2.

* fix: adapt tailwind merge config

* fix: adapt tailwind merge config

* fix: adapt tailwind merge config

* fix: changeset

* ci(changesets): version packages (beta)

* fix(tailwind): add missing values config for bg-grid plugin

* fix: remove useless tw config

* fix: add default styles

* docs: changeset

* docs: typo

* chore: merge origin canary to beta

* ci(changesets): version packages (beta)

* chore: remove changeset & pre.json

* chore: change to minor

* chore(pre-release): enter pre-release mode

* chore(deps): fix versions

* chore(deps): revise changed packages

* chore(deps): update tailwindcss version

* ci(changesets): 📦 version packages (beta) (#5166)

* ci(changesets): version packages (beta)

* fix: add missing delimiter

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: winches <329487092@qq.com>

* fix(docs): add missing semicolon

* fix: animate about skeleton (#5198)

* chore: pre release

* ci(changesets): version packages (beta) (#5199)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* docs: blurred hover button style

* fix: language selector blur (#5208)

* fix: skeleton animate translate value (#5207)

* fix: open in remote repo (#5214)

* chore: upgrade tw version

* fix: open in remote repo

* fix: update lock

* fix: select translate styles (#5219)

* chore: pre release

* ci(changesets): version packages (beta) (#5222)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore: remove changeset

* chore(pre-release): enter pre-release mode

* chore(react): continue from 2.8.0-beta.2

* chore(changeset): add changeset

* fix(changeset): use patch

* ci(changesets): version packages (beta)

* fix(docs): beta docs

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: winches <329487092@qq.com>
Co-authored-by: WK Wong <wingkwong.code@gmail.com>
Co-authored-by: Junior Garcia <jrgarciadev@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Charlotte21110 <hejianer9@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💥 Type: Breaking Change This PR includes breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]Tailwind v4 support.