fix(dropdown): invalid dropdown menu position by jijiseong · Pull Request #4471 · heroui-inc/heroui

jijiseong · 2024-12-31T11:45:25Z

📝 Description

placementProps was converted to PlacementAxis type
using toReactAriaPlacement and useOverlayPosition

// react-aria/overlay

// ...

export type Axis = 'top' | 'bottom' | 'left' | 'right';
export type PlacementAxis = Axis | 'center';

e.g.)
bottom-end -> (toReactAriaPlacement) -> bottom right -> (useOverlayPosition) -> bottom
bottom-start -> (toReactAriaPlacement) -> bottom left -> (useOverlayPosition) -> bottom
top-start -> (toReactAriaPlacement) -> top left -> (useOverlayPosition) -> top

We want use the original placement instead of converting it to PlacementAxis.
So I delete the conversion logic.

⛳️ Current behavior (updates)

2024-12-31.8.38.22.mov

🚀 New behavior

2024-12-31.8.40.14.mov

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

Dependency Update
- Patched @nextui-org/dropdown dependency
Improvements
- Simplified dropdown positioning logic
- Removed complex overlay positioning calculations
- Streamlined dropdown configuration options

changeset-bot · 2024-12-31T11:45:28Z

🦋 Changeset detected

Latest commit: b3ffa54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/dropdown	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-12-31T11:45:29Z

@jijiseong is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2024-12-31T11:45:31Z

Walkthrough

The pull request introduces changes to the dropdown component's positioning logic by removing overlay-related imports and simplifying the placement configuration. The modifications in the use-dropdown.ts file remove previous complex positioning calculations, instead directly using the placementProp for dropdown placement. A patch for the @nextui-org/dropdown dependency is also added, suggesting minor updates to the package.

Changes

File	Change Summary
`.changeset/silly-hotels-stare.md`	Added patch for `@nextui-org/dropdown` dependency
`packages/components/dropdown/src/use-dropdown.ts`	- Removed `useOverlayPosition` import - Deleted overlay positioning parameters (`containerPadding`, `offset`, etc.) - Simplified placement logic by directly using `placementProp`

Assessment against linked issues

Objective	Addressed	Explanation
Fix Dropdown Arrow Positioning [#4466]	✅
Correct Placement Behavior	✅

Possibly related PRs

fix(dropdown): unnecessary ref in dropdown #4278: Removal of unnecessary ref in dropdown component
fix(dropdown): correct initial animation direction to match fallback placement #4288: Correction of initial dropdown animation direction
fix(popover): correct initial animation direction to match fallback placement #4460: Popover animation direction correction

Suggested reviewers

wingkwong
jrgarciadev

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbef9c8 and b3ffa54.

📒 Files selected for processing (1)

.changeset/silly-hotels-stare.md (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.changeset/silly-hotels-stare.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

.changeset/silly-hotels-stare.md (1)

1-6: Changeset reference looks good.
Patching @nextui-org/dropdown and @nextui-org/popover with a brief note describing the removal of the conversion logic is concise and clear. Consider adding a reference to the PR or the issue number (#4466) to provide further context for maintainers and collaborators.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d92468a and bbef9c8.

📒 Files selected for processing (3)

.changeset/silly-hotels-stare.md (1 hunks)
packages/components/dropdown/src/use-dropdown.ts (2 hunks)
packages/components/popover/src/popover.tsx (0 hunks)

💤 Files with no reviewable changes (1)

packages/components/popover/src/popover.tsx

🔇 Additional comments (2)

packages/components/dropdown/src/use-dropdown.ts (2)

12-12: Confirm usage of ariaShouldCloseOnInteractOutside is fully compatible with your existing logic.
It's great to see the usage of ariaShouldCloseOnInteractOutside for controlling interactions outside the dropdown. Ensure that its return behavior aligns with all desired edge cases, such as when nested elements or extended custom triggers are used.

151-151: Placement is now derived directly from placementProp.
Removing the intermediate logic significantly simplifies the code. However, verify that passing any advanced values (e.g., bottom-end) is correctly handled by the underlying popover logic.

vercel · 2024-12-31T12:33:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 0:38am
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 0:38am

wingkwong

may double check if the issue occurs in tooltip / popover or not as well

jijiseong · 2024-12-31T13:48:39Z

may double check if the issue occurs in tooltip / popover or not as well

tooltip and popover work well

2024-12-31.10.44.47.mov

2024-12-31.10.40.43.mov

jijiseong · 2025-01-01T05:02:03Z

The Dropdown with arrow case also works well

mohammadshahidbeigh · 2025-01-02T19:04:44Z

Hi @wingkwong, I'm interested in working on this issue if it's still unresolved. Could you please assign it to me? Thanks!

jrgarciadev · 2025-01-02T19:09:10Z

@ryo-manba please confirm if this was also fixed on this PR #4460

jijiseong · 2025-01-03T04:36:18Z

@ryo-manba please confirm if this was also fixed on this PR #4460

PR #4460 is about animation
But this is about DropDown positioning
It is different issue

ryo-manba · 2025-01-05T01:34:34Z

I checked with Storybook and there seems to be an animation problem.
This issue is complicated, I'll look into it later.

ryo-manba · 2025-01-05T09:26:32Z

Hi @jijiseong, Thank you for creating the PR!
Since this issue involved several other bugs, I created a separate PR to address them.
Therefore, I will close this PR.
We look forward to your future contributions!

jijiseong added 2 commits December 31, 2024 20:21

fix(dropdown): invalid dropdown menu position

de4cc39

chore: add changeset

bbef9c8

jijiseong requested a review from jrgarciadev as a code owner December 31, 2024 11:45

coderabbitai Bot reviewed Dec 31, 2024

View reviewed changes

wingkwong added this to the v2.6.11 milestone Dec 31, 2024

vercel Bot deployed to Preview – nextui-docs-v2 December 31, 2024 12:35 View deployment

vercel Bot deployed to Preview – nextui-storybook-v2 December 31, 2024 12:38 View deployment

wingkwong requested changes Dec 31, 2024

View reviewed changes

Comment thread packages/components/popover/src/popover.tsx

Comment thread .changeset/silly-hotels-stare.md Outdated

Comment thread .changeset/silly-hotels-stare.md Outdated

wingkwong requested a review from ryo-manba December 31, 2024 13:03

chore: modified changeset, undo line space change

b3ffa54

jijiseong requested a review from wingkwong December 31, 2024 14:26

jrgarciadev removed this from the v2.6.11 milestone Jan 2, 2025

ryo-manba closed this Jan 5, 2025

jijiseong deleted the fix/dropdown-position branch January 6, 2025 13:07

Uh oh!

Conversation

jijiseong commented Dec 31, 2024 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented Dec 31, 2024

Uh oh!

coderabbitai Bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

vercel Bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wingkwong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jijiseong commented Dec 31, 2024

Uh oh!

jijiseong commented Jan 1, 2025

Uh oh!

mohammadshahidbeigh commented Jan 2, 2025

Uh oh!

jrgarciadev commented Jan 2, 2025

Uh oh!

jijiseong commented Jan 3, 2025

Uh oh!

ryo-manba commented Jan 5, 2025

Uh oh!

ryo-manba commented Jan 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jijiseong commented Dec 31, 2024 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Dec 31, 2024 •

edited

Loading

coderabbitai Bot commented Dec 31, 2024 •

edited

Loading

vercel Bot commented Dec 31, 2024 •

edited

Loading